adapter: always use enable_for_item_parsing when applying state #34476
+125
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
apply-always-enable_for_item_parsing
branch
from
f253a5a to
d749634
Compare
The logic for applying `StateUpdate`s from the durable catalog previously only switched on the `enable_for_item_parsing` feature flags when applying item updates during bootstrap. Thus, the process would crash when updating an item that depends on disabled feature flag after the bootstrap phase. We must respect `enable_for_item_parsing` also in steady-state, after bootstrap. The SQL contained in these `StateUpdate`s has already been made durable in the catalog, so we can't reject it anymore and need to do our best to parse it. This commit achieves that by merging the `apply_updates` and `apply_updates_for_bootstrap` methods into a single one that always enables `enable_for_item_parsing` features when applying item updates.
teskje
force-pushed
the
apply-always-enable_for_item_parsing
branch
from
d749634 to
d601be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for applying
StateUpdates from the durable catalog previously only switched on theenable_for_item_parsingfeature flags when applying item updates during bootstrap. Thus, the process would crash when updating an item that depends on disabled feature flag after the bootstrap phase.We must respect
enable_for_item_parsingalso in steady-state, after bootstrap. The SQL contained in theseStateUpdates has already been made durable in the catalog, so we can't reject it anymore and need to do our best to parse it.This PR achieves that by merging the
apply_updatesandapply_updates_for_bootstrapmethods into a single one that always enablesenable_for_item_parsingfeatures when applying item updates.Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/9971
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.