Skip to content

Conversation

@martykulma
Copy link
Contributor

@martykulma martykulma commented Dec 12, 2025

Add config variable sql_server_source_validate_restore_history to control SQL server restore history validation behavior.

The default behavior of emitting a definite error remains the same. If validation is disabled, detecting a restore history change will only elicit a warning in the logs.

This also adds 2 checks to dataflow startup to ensure CDC is enabled and the agent is running. CDC requires extra steps after an AOAG failover, without validation, MZ might appear to never make progress because CDC is not actively running.

Motivation

Adds feature https://linear.app/materializeinc/issue/SS-28

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@martykulma martykulma force-pushed the maz-sql-server-trusted-failover branch from 49a16e2 to 3d3c171 Compare December 17, 2025 22:07
@martykulma martykulma marked this pull request as ready for review December 17, 2025 22:18
@martykulma martykulma requested review from a team as code owners December 17, 2025 22:18
Copy link
Member

@DAlperin DAlperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I trust big tech!

@martykulma
Copy link
Contributor Author

TFTR!

@martykulma martykulma merged commit 5222744 into MaterializeInc:main Dec 18, 2025
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants