Bugs fixed and Updated many things #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace cargo with cargo-ndk for better Android compatibility - Add Windows support with automatic rustup installation - Implement Gradle build cache support with proper task annotations - Enable parallel ABI builds - Add comprehensive build validation - Improve error messages with actionable suggestions - Auto-install cargo-ndk if missing
Critical Fixes: - Fix cargo-ndk invocation: use 'cargo ndk' instead of direct 'cargo-ndk' binary - Add ANDROID_NDK_HOME environment variable for cargo-ndk compatibility - Auto-detect Rust installation path (~/.cargo/bin, CARGO_HOME) - Improve error handling for missing Rust toolchain - Add graceful version detection fallback These fixes resolve: - 'This binary may only be called via cargo ndk' error - Requirement to manually set cargo.bin in local.properties - Build failures when Rust is not in system PATH
Owner
|
@rodroidmods, thanks for your contribution. this PR has quite a few changes though, I will try to find time to review it in the near future. |
- Add new CargoCleanTask that runs cargo clean for Rust modules - Add cargoClean configuration option at extension, module, and build type levels - Register cargoClean task to clean all modules - Register cargoClean<ModuleName> tasks for individual modules - Auto-hook cargoClean to Gradle clean task when cargoClean = true is set - Update README.md with new feature documentation - Update AGP to 8.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the description on https://github.com/rodroidmods/GradleAndroidRustPlugin/releases/tag/v0.7.0 and on tag v0.6.0 too