This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Fix missing commits & misc.#3
Open
ArshansGithub wants to merge 1 commit into
Open
Conversation
Author
|
Hello just bumping this PR since the entire extension is essentially broken and doesn't do what its supposed to do :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for developing such a useful extension. I came across an issue at competition where when using this extension, changes were only being staged and not commited. Taking a look today, I noticed that the commit message wasn't being passed in properly
I also simplified some of the git command (using -a flag)
Before:
git add -A
git commit -m "Update at "3/31/2024, 11:39:22 AM""
After:
git commit -a -m "Deploy at \"3/31/2024, 11:39:22 AM\""
I also changed the message from update to deploy since the code is only 'updated' per each deploy rather than using the word 'update'. I feel like the word 'update' would make more sense if it was per save of file but since this automatically commits on deploy it makes more sense to use 'deploy'. Just my opinion though.