Conversation
1e263fa to
beba6a5
Compare
|
Tried to improve the |
e48e6ae to
cd6c6b7
Compare
|
MediaInfoLib/Source/MediaInfo/Audio/File_Ac3.cpp Lines 4256 to 4261 in d93cc8c Does not seem to match specs:
|
9b36853 to
ad3e853
Compare
|
Not related to this PR but noticed that for raw TrueHD stream, even with full parse, there is no duration and bitrate in output. |
It was not implemented for full parse, but should be easy, I'll give it a look. |
c5ed93d to
f20490e
Compare
b505215 to
267ac10
Compare
|
Malformed EMDF E-AC3 samples that can crash Dolby's official decoders (CVE-2025-54957) may be useful for testing and can be found here: |
- Remove redundant codes - Remove unused variables - Fix padding handling
|
FYI I checked with all files I have but some files with JOC are no more detected, I'll work on finding the source of the regression in your code. |
|
This PR is just for expanding MediaTrace and getting more info from TrueHD and DRC info from some JOC as well as trying to improve the display when both TrueHD and Ac3 in same track (but still not well done yet). It should not affect which files are parsed or not so
No. |
|
One more thing is I think the metadata from AC3 (dialnorm and many lines at the bottom) should not be shown when TrueHD and AC3 in the same track and legacy stream display is not enabled. That AC3 DRC data is not used by TrueHD. Some people may misinterpret it or find it strange that when remuxed to MKV for example and the TrueHD is split from AC3, the TrueHD track no longer has such metadata. |
More parsing and improved trace output for Dolby TrueHD. I put some of the new codes under a TrueHD/FBA check since I do not have MLP/FBB info or samples to know if it is the same.