Skip to content

ci: update OFED version to doca3.3.0-26.01-0.9.5.0.839-0#2639

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-0.9.5.0.839-0
Closed

ci: update OFED version to doca3.3.0-26.01-0.9.5.0.839-0#2639
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-0.9.5.0.839-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Jun 4, 2026

Copy link
Copy Markdown

Greptile Summary

This automated CI PR replaces the OFED/DOCA driver version string across all example CRs and hack/release.yaml, but the change is a downgrade from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 — both the DOCA major version and the MLNX_OFED stream regress.

  • All 7 example NicClusterPolicy CRs have their ofedDriver.version rolled back from doca3.4.0 (MLNX_OFED 26.04) to doca3.3.0 (MLNX_OFED 26.01).
  • hack/release.yaml has both Mofed and MofedStigFips entries downgraded consistently with the CRs.
  • All references still point to the nvcr.io/nvstaging/mellanox staging registry, unchanged from before.

Confidence Score: 4/5

The change is mechanically consistent across all 8 files, but rolls the driver back to an older DOCA/OFED release rather than forward — human confirmation that this downgrade is deliberate is recommended before merging.

Every file is updated identically and no logic, schema, or configuration is broken. The only concern is that the automated CI job produced a version regression (3.4.0 → 3.3.0, 26.04 → 26.01) rather than a forward bump, which could indicate the job picked up the wrong build or was triggered for an older release branch.

hack/release.yaml — contains both Mofed and MofedStigFips entries and is the canonical source of truth for the version; worth a second look to confirm the intended target version.

Important Files Changed

Filename Overview
hack/release.yaml Downgrades both Mofed and MofedStigFips entries from doca3.4.0-26.04 to doca3.3.0-26.01; this is a version regression that warrants explicit confirmation
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full-ocp.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp-hostdev.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml OFED driver version bumped from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 (downgrade)

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[hack/release.yaml] -->|Mofed version| B["doca3.4.0-26.04-0.8.6.0-0 ➜ doca3.3.0-26.01-0.9.5.0.839-0"]
    A -->|MofedStigFips version| B
    C[7x example NicClusterPolicy CRs] -->|ofedDriver.version| B
    B --> D{Intended downgrade?}
    D -->|Yes| E[Safe to merge]
    D -->|No| F[Revert needed]
Loading

Reviews (1): Last reviewed commit: "ci: update OFED version to doca3.3.0-26...." | Re-trigger Greptile

Comment thread hack/release.yaml
Comment on lines 51 to 52
image: doca-driver
repository: nvcr.io/nvstaging/mellanox

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version downgrade, not an upgrade

This PR rolls the OFED/DOCA version back from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.839-0 — both the DOCA major version (3.4 → 3.3) and the MLNX_OFED stream (26.04 → 26.01) regress. The PR title calls it an "update," but given that the source is an automated internal CI job it is worth confirming that this downgrade is intentional and that the newer 3.4.0 driver was deliberately superseded rather than accidentally reverted. The same rollback is applied identically across all 7 example CRs and release.yaml.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@rollandf rollandf closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants