Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
2 changes: 1 addition & 1 deletion example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
ofedDriver:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
upgradePolicy:
autoUpgrade: true
drain:
Expand Down
4 changes: 2 additions & 2 deletions hack/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ SriovIbCni:
Mofed:
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
MofedStigFips:
image: doca-driver-stig-fips
Comment on lines 51 to 55

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version appears to be a downgrade

The DOCA version is changing from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.840-0, which is a step backward in both the DOCA major version (3.4.0 → 3.3.0) and the OFED version (26.04 → 26.01). If this is an intentional switch to a different (e.g., more stable) release branch rather than a rollback, a note in the PR description explaining the rationale would help reviewers confirm this is correct.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
RdmaSharedDevicePlugin:
image: k8s-rdma-shared-dev-plugin
repository: nvcr.io/nvstaging/mellanox
Expand Down
Loading