Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Stopping a wrapper left the real command running. memnox-shell and memnox-intercept now forward SIGTERM and SIGHUP to the command and stop listening once it exits. memnox-intercept exits 143 or 129 rather than 1. The shared helpers live in a new
child-signals.ts.How it was verified
packages/interceptors/test/child-signals.test.tssends SIGTERM and SIGHUP to a realsleep 30through an injected source. It checks the exit code, that the process is gone and that the listeners are removed. The test exercises the shared helper rather than the built binaries.Fixes #17
Checklist
pnpm format && pnpm typecheck && pnpm test && pnpm deadcodeall passany, no magic values, noconsole.*outsidecli-output.tsdocs/says so (not applicable)