Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
memnox-shell dropped the words after the
-cline and switched to argv mode on a--that came after-c. It also ranpipefailin-o pipefail -c cmdas if it were a script. The parser now reads arguments left to right.-o,+o,-O,+O,--rcfileand--init-filetake their value with them. The newcommandShellArgspasses$0,$1and"$@"to the real shell unchanged.How it was verified
packages/interceptors/test/shell-line.test.tshas a parser test for each of the three forms in the issue. Another test runs/bin/shwith whatcommandShellArgsreturns and checks the output.Fixes #15
Checklist
pnpm format && pnpm typecheck && pnpm test && pnpm deadcodeall passany, no magic values, noconsole.*outsidecli-output.tsdocs/says so (not applicable)