Fix issue 83 slider range #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Reversed y-axis ordering for non-reference groups in prop plots - Reversed y-axis ordering for diff plots - Ensures consistent visual ordering between table and interactive plots 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added Plotly.js integration information - Documented sparkline_point_js() function - Added brew and plotly dependencies - Included notes about JavaScript templates and debugging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added display_n and display_prop flags that are set based on the display parameter. Modified column definitions to include show attribute that respects these flags. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added col_header and fig_header parameters to format_ae_forestly() - Headers now dynamically use the actual reference group name instead of hardcoded "Placebo" - Users can provide custom headers if needed - Maintains backward compatibility with sensible defaults 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Exclude CLAUDE.md from R package build to prevent R CMD check issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added filter_range parameter to ae_forestly() function - Supports NULL (auto-detect), single value (max only), or two values (min/max) - Auto-detection rounds to nearest 5/10 for better UX - Removes hardcoded limit of 100 for the slider - Properly handles both proportion and count filters 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
elong0527
force-pushed
the
fix-issue-83-slider-range
branch
from
2cf1039 to
699752f
Compare
wangben718
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is to close #83 that allow user to set up filter range in the side bar.