chore(subscription-controller): replace Sinon with Jest fake timers

[cryptodev-2s]

Explanation

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Low Risk
Test-only changes and devDependency cleanup; risk is limited to potential timer behavior differences causing flaky or failing tests.

Overview
subscription-controller tests now use Jest’s fake timers (jest.useFakeTimers()/jest.useRealTimers()) and the shared jestAdvanceTime helper instead of Sinon’s useFakeTimers() plus advanceTime.

Removes sinon from packages/subscription-controller devDependencies (and yarn.lock), reducing test-only dependency surface and standardizing on Jest timer utilities.

^{Written by Cursor Bugbot for commit 137ff57. This will update automatically on new commits. Configure here.}