feat(tron-wallet-snap): route asset reads through Core when migration is on - #145
Open
ulissesferreira wants to merge 1 commit into
Open
feat(tron-wallet-snap): route asset reads through Core when migration is on#145ulissesferreira wants to merge 1 commit into
ulissesferreira wants to merge 1 commit into
Conversation
This was referenced Aug 10, 2026
ulissesferreira
force-pushed
the
WPN-1497-implement-core-assets-adapter
branch
from
August 10, 2026 14:13
714b17d to
3550d24
Compare
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 10, 2026 14:14
ba86a26 to
25080b8
Compare
This was referenced Aug 10, 2026
ulissesferreira
force-pushed
the
WPN-1497-implement-core-assets-adapter
branch
from
August 10, 2026 15:07
3550d24 to
a42b752
Compare
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 10, 2026 15:35
46681f7 to
e73dd2e
Compare
ulissesferreira
force-pushed
the
WPN-1497-implement-core-assets-adapter
branch
4 times, most recently
from
August 14, 2026 12:49
69e150f to
cc94a88
Compare
ulissesferreira
marked this pull request as draft
August 14, 2026 13:29
Base automatically changed from
WPN-1497-implement-core-assets-adapter
to
main
August 14, 2026 13:50
4 tasks
cursor
Bot
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 18, 2026 10:00
c0bae22 to
084b8c7
Compare
6 tasks
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
2 times, most recently
from
August 25, 2026 17:52
e5c9702 to
6aa1f0a
Compare
ulissesferreira
changed the base branch from
main
to
fix/map-controller-asset-display-balance
August 25, 2026 17:52
ulissesferreira
force-pushed
the
fix/map-controller-asset-display-balance
branch
2 times, most recently
from
August 26, 2026 12:56
818a716 to
4be4426
Compare
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 26, 2026 13:07
6aa1f0a to
32c46a3
Compare
ulissesferreira
force-pushed
the
fix/map-controller-asset-display-balance
branch
from
August 26, 2026 13:13
8bfe50d to
681e0cb
Compare
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 26, 2026 13:27
5a9e4a0 to
4641aa1
Compare
Base automatically changed from
fix/map-controller-asset-display-balance
to
main
August 26, 2026 13:55
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 26, 2026 13:58
4641aa1 to
ccfc1c6
Compare
ulissesferreira
marked this pull request as ready for review
August 26, 2026 14:23
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
3 times, most recently
from
August 27, 2026 11:45
a5cd442 to
89b4f7e
Compare
Contributor
Author
|
Reopening to re-trigger CI after amend |
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
4 times, most recently
from
August 28, 2026 10:41
783bc2f to
396c3af
Compare
ulissesferreira
force-pushed
the
WPN-1497-route-assets-logic-based-on-feature-flag
branch
from
August 28, 2026 10:46
396c3af to
05bd174
Compare
Contributor
|
nit: the Changelog file is updated so seems to me that the PR label should not have the |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds feature-flagged routing between Snap-managed assets and Core’s AssetsController.
Changes:
- Adds migration-aware asset read, fetch, and save routing.
- Injects the remote feature-flags provider.
- Adds migration tests and release metadata updates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
AssetsService.ts |
Implements feature-flagged adapter routing. |
AssetsService.test.ts |
Adds migration routing tests. |
context.ts |
Injects the feature-flags provider. |
snap.manifest.json |
Updates the bundle checksum. |
CHANGELOG.md |
Documents the migration behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+56
to
+58
| const result = | ||
| parseSnapsAssetsMigrationStage(flagValue) !== | ||
| SnapsAssetsMigrationStage.Off; |
Contributor
Author
There was a problem hiding this comment.
This is by design. We decided against having the extra fallback complexity so we just have a on or off type of situation
|
|
||
| describe('facade delegation', () => { | ||
| it('delegates repository reads and market helpers to SnapAssetsAdapter', async () => { | ||
| it('delegates static helpers and empty batch reads to SnapAssetsAdapter', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteFeatureFlagsProviderintoAssetsServiceand resolve the Tron assets migration flag via#shouldReturnAssetsFromCoregetAccountAssetByID,getAccountAssetsByIDs,getAccountAssets,fetchAssetsAndBalancesForAccount, andsaveManythrough Core when migration is activePart of WPN-1497. Stack:
Replaces outdated #127 / #141.
Test plan
yarn workspace @metamask/tron-wallet-snap run buildyarn workspace @metamask/tron-wallet-snap run jest --no-coverage src/services/assets/AssetsService.test.tssaveManyemits only snap-owned assets and does not persist fungibles locally