feat(tron-wallet-snap): route asset reads through Core when migration is on by ulissesferreira · Pull Request #145 · MetaMask/internal-snaps

ulissesferreira · 2026-08-10T14:13:24Z

Summary

Pass RemoteFeatureFlagsProvider into AssetsService and resolve the Tron assets migration flag via #shouldReturnAssetsFromCore
Route getAccountAssetByID, getAccountAssetsByIDs, getAccountAssets, fetchAssetsAndBalancesForAccount, and saveMany through Core when migration is active
When migration is on, fetch returns only snap-owned assets; save publishes them via keyring events without local persistence

Part of WPN-1497. Stack:

refactor(tron-wallet-snap): extract shared asset utils and inject SnapAssetsAdapter #143
feat(tron-wallet-snap): add CoreAssetsAdapter and mapControllerAsset #144
feat(tron-wallet-snap): route asset reads through Core when migration is on #145 (this PR)

Replaces outdated #127 / #141.

Test plan

yarn workspace @metamask/tron-wallet-snap run build
yarn workspace @metamask/tron-wallet-snap run jest --no-coverage src/services/assets/AssetsService.test.ts
With migration flag off: asset reads/writes/fetch behave as Snap-only
With migration flag on: fungible reads come from AssetsController; fetch returns only snap-owned assets; saveMany emits only snap-owned assets and does not persist fungibles locally

ulissesferreira · 2026-08-27T11:47:43Z

Reopening to re-trigger CI after amend

… is on

Battambang · 2026-08-28T12:10:39Z

nit: the Changelog file is updated so seems to me that the PR label should not have the no-changelog label

Copilot

Pull request overview

Adds feature-flagged routing between Snap-managed assets and Core’s AssetsController.

Changes:

Adds migration-aware asset read, fetch, and save routing.
Injects the remote feature-flags provider.
Adds migration tests and release metadata updates.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`AssetsService.ts`	Implements feature-flagged adapter routing.
`AssetsService.test.ts`	Adds migration routing tests.
`context.ts`	Injects the feature-flags provider.
`snap.manifest.json`	Updates the bundle checksum.
`CHANGELOG.md`	Documents the migration behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

ulissesferreira · 2026-08-28T14:49:22Z

+    const result =
+      parseSnapsAssetsMigrationStage(flagValue) !==
+      SnapsAssetsMigrationStage.Off;


This is by design. We decided against having the extra fallback complexity so we just have a on or off type of situation

ulissesferreira · 2026-08-28T14:50:53Z

+
  describe('facade delegation', () => {
-    it('delegates repository reads and market helpers to SnapAssetsAdapter', async () => {
+    it('delegates static helpers and empty batch reads to SnapAssetsAdapter', async () => {


I though about adding some extra coverage but decided against it due to number of changes. Maybe I should 🤔. Thinking of maybe in a follow up PR?

In that current case, that would upsize the PR without big enhancement.
This current state is acceptable.

ulissesferreira · 2026-08-28T14:51:20Z

nit: the Changelog file is updated so seems to me that the PR label should not have the no-changelog label

Absolutely right. I noticed this, added the Changelog and then completely forgot to remove the label. Great catch!

ulissesferreira requested a review from a team as a code owner August 10, 2026 14:13

This was referenced Aug 10, 2026

feat(tron-wallet-snap): route assets through Core AssetsController #127

Closed

feat(tron-wallet-snap): add CoreAssetsAdapter and initialize in AssetsService #141

Closed

ulissesferreira force-pushed the WPN-1497-implement-core-assets-adapter branch from 714b17d to 3550d24 Compare August 10, 2026 14:13

ulissesferreira requested a review from a team as a code owner August 10, 2026 14:13

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from ba86a26 to 25080b8 Compare August 10, 2026 14:14

This was referenced Aug 10, 2026

refactor(tron-wallet-snap): extract shared asset utils and inject SnapAssetsAdapter #143

Merged

feat(tron-wallet-snap): add CoreAssetsAdapter and mapControllerAsset #144

Merged

ulissesferreira force-pushed the WPN-1497-implement-core-assets-adapter branch from 3550d24 to a42b752 Compare August 10, 2026 15:07

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from 46681f7 to e73dd2e Compare August 10, 2026 15:35

ulissesferreira force-pushed the WPN-1497-implement-core-assets-adapter branch 4 times, most recently from 69e150f to cc94a88 Compare August 14, 2026 12:49

ulissesferreira marked this pull request as draft August 14, 2026 13:29

Base automatically changed from WPN-1497-implement-core-assets-adapter to main August 14, 2026 13:50

cursor Bot mentioned this pull request Aug 14, 2026

feat(solana-wallet-snap): route asset reads through Core when migration is on #123

Draft

4 tasks

cursor Bot force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from c0bae22 to 084b8c7 Compare August 18, 2026 10:00

ulissesferreira mentioned this pull request Aug 18, 2026

test(tron-wallet-snap): slim AssetsService tests to façade delegation #162

Closed

6 tasks

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch 2 times, most recently from e5c9702 to 6aa1f0a Compare August 25, 2026 17:52

ulissesferreira added the no-changelog label Aug 25, 2026

ulissesferreira changed the base branch from main to fix/map-controller-asset-display-balance August 25, 2026 17:52

ulissesferreira force-pushed the fix/map-controller-asset-display-balance branch 2 times, most recently from 818a716 to 4be4426 Compare August 26, 2026 12:56

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from 6aa1f0a to 32c46a3 Compare August 26, 2026 13:07

ulissesferreira force-pushed the fix/map-controller-asset-display-balance branch from 8bfe50d to 681e0cb Compare August 26, 2026 13:13

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from 5a9e4a0 to 4641aa1 Compare August 26, 2026 13:27

Base automatically changed from fix/map-controller-asset-display-balance to main August 26, 2026 13:55

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from 4641aa1 to ccfc1c6 Compare August 26, 2026 13:58

ulissesferreira marked this pull request as ready for review August 26, 2026 14:23

ulissesferreira deployed to default-branch August 26, 2026 14:23 — with GitHub Actions Active

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch 3 times, most recently from a5cd442 to 89b4f7e Compare August 27, 2026 11:45

ulissesferreira closed this Aug 27, 2026

ulissesferreira reopened this Aug 27, 2026

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch 4 times, most recently from 783bc2f to 396c3af Compare August 28, 2026 10:41

feat(tron-wallet-snap): route asset reads through Core when migration…

05bd174

… is on

ulissesferreira force-pushed the WPN-1497-route-assets-logic-based-on-feature-flag branch from 396c3af to 05bd174 Compare August 28, 2026 10:46

Battambang requested a balanced review from Copilot August 28, 2026 12:11

Copilot started reviewing on behalf of Battambang August 28, 2026 12:11 View session

Copilot AI reviewed Aug 28, 2026

View reviewed changes

ulissesferreira removed the no-changelog label Aug 28, 2026

Battambang approved these changes Aug 28, 2026

View reviewed changes

ulissesferreira added this pull request to the merge queue Aug 28, 2026

Merged via the queue into main with commit bf7378a Aug 28, 2026
56 checks passed

ulissesferreira deleted the WPN-1497-route-assets-logic-based-on-feature-flag branch August 28, 2026 15:35

Navigation Menu

Uh oh!

feat(tron-wallet-snap): route asset reads through Core when migration is on - #145

feat(tron-wallet-snap): route asset reads through Core when migration is on#145
ulissesferreira merged 1 commit into
mainfrom
WPN-1497-route-assets-logic-based-on-feature-flag

ulissesferreira commented Aug 10, 2026 •

edited

Loading

Uh oh!

ulissesferreira commented Aug 27, 2026

Uh oh!

Battambang commented Aug 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ulissesferreira Aug 28, 2026

Uh oh!

ulissesferreira Aug 28, 2026

Uh oh!

Battambang Aug 28, 2026

Uh oh!

Uh oh!

ulissesferreira commented Aug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ulissesferreira commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

ulissesferreira commented Aug 27, 2026

Uh oh!

Battambang commented Aug 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ulissesferreira Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

ulissesferreira Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Battambang Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ulissesferreira commented Aug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ulissesferreira commented Aug 10, 2026 •

edited

Loading