Skip to content

test(tron-wallet-snap): remove before each usage in useCache - #223

Merged
gabrieledm merged 24 commits into
mainfrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache
Aug 27, 2026
Merged

test(tron-wallet-snap): remove before each usage in useCache#223
gabrieledm merged 24 commits into
mainfrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache

Conversation

@gabrieledm

@gabrieledm gabrieledm commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Explanation

Refactor of tests under packages/tron-wallet-snap/src/caching/useCache.test.ts to remove the usage of beforeEach and follow the Unit Testing Guidelines

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@gabrieledm
test: added shape of setup function and its arguments
c1921e0
@gabrieledm
doc: added JSDoc for withUseCache setup function
75760e9
@gabrieledm
test: added cache in returned object of withUseCache
9d84a66
@gabrieledm
test: used setup function in 'when the data is not cached' tests
d27dc5a
@gabrieledm
test: removed usage of spyOn for cache mock
20de373
@gabrieledm
test: temporary disabled ts rules to make the ci happy
f3059f9
@gabrieledm
test: used setup function in 'when the data is cached' tests
f3f62e2
@gabrieledm
test: removed usage of spyOn for cache mock
4505609
@gabrieledm
test: used setup function in 'error handling' tests
9c55ffc
@gabrieledm
test: removed usage of spyOn for cache mock
e0c2ae1
@gabrieledm
test: used setup function in 'different argument types' tests
0cee946
@gabrieledm
test: temporary disabled ts rules to make the ci happy
99a7bc0 
# Conflicts:
#	packages/tron-wallet-snap/src/caching/useCache.test.ts
@gabrieledm
test: temporary disabled ts rules to make the ci happy
51cc117
@gabrieledm
test: used setup function in 'custom generateCacheKey' tests
b0dd59e
@gabrieledm
test: used setup function in 'anonymous functions' tests
395957c
@gabrieledm
test: used setup function in 'function name override' tests
a7010fb
@gabrieledm
test: temporary disabled no-shadow ts rule to make the ci happy
1ccde1d
@gabrieledm
test: used setup function in 'falsy but valid cache values' tests
54f4bdc
@gabrieledm
fix: added missed CacheOptions type
85e71fe
@gabrieledm
chore: prune suppressions
8411214
@gabrieledm
chore: lint fix
c101a7e
@gabrieledm
chore: shasum
6e8bbea 
# Conflicts:
#	packages/tron-wallet-snap/snap.manifest.json
@gabrieledm
chore: shasum
7d1ff68
@gabrieledm
test: removed es lint disable rule
9d3c494
@gabrieledm
gabrieledm requested review from a team as code owners August 27, 2026 14:55
@gabrieledm
gabrieledm deployed to default-branch August 27, 2026 14:55 — with GitHub Actions Active
@gabrieledm gabrieledm changed the title Gabrieledm/tests/tron/remove before each usage in use cache test(tron-wallet-snap): remove before each usage in useCache Aug 27, 2026
@gabrieledm
gabrieledm added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 442a3d1 Aug 27, 2026
104 checks passed
@gabrieledm
gabrieledm deleted the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache branch August 27, 2026 15:27
This was referenced Aug 27, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulissesferreira ulissesferreira ulissesferreira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrieledm @ulissesferreira