feat(tron-wallet-snap): remove assets migration feature-flag routing - #97
Draft
ulissesferreira wants to merge 2 commits into
Draft
feat(tron-wallet-snap): remove assets migration feature-flag routing#97ulissesferreira wants to merge 2 commits into
ulissesferreira wants to merge 2 commits into
Conversation
After rollout, always route fungible reads through AssetsController via AssetsProvider. Snap-owned protocol assets remain on the Snap adapter. Remove RemoteFeatureFlagController endowment and migration stage logic.
ulissesferreira
marked this pull request as draft
August 3, 2026 09:19
…sProvider routing - Slim SnapAssetsAdapter to snap-owned fetch/save/read only (fetchSnapOwnedAssetsForAccount) - Move handler logic (metadata, conversions, market data, historical prices) into AssetsService - Add syncSnapOwnedAssets for cron sync; AccountsService.synchronizeAssets delegates to it - Keep PR97 fungible read routing via AssetsProvider for getAccountAssetByID/ByIDs/ByScope - Remove public saveMany, getAll, fetchAssetsAndBalancesForAccount, hasChanged from AssetsService - Drop unused state from AssetsService constructor in context.ts - Port and adapt unit tests; update eslint suppressions and changelog Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SnapsAssetsMigrationStage/ remote feature-flag resolution fromAssetsServiceandSnapAssetsAdaptergetAccountAssetByID,getAccountAssetsByIDs,getAccountAssetsByScope) through CoreAssetsControllerviaAssetsProviderRemoteFeatureFlagController:getStatemessenger endowment and@metamask/remote-feature-flag-controllerdevDependencyPR chain
#90 → #91 → #92 → #95 → #96 → this PR
Test plan
yarn workspace @metamask/tron-wallet-snap run jest --no-coverage src/services/assets/AssetsService.test.ts