chore: bump tron snap to v2.0.0, bump bitcoin snap to v2.0.0 - #45142
Open
taran-a wants to merge 1 commit into
Open
chore: bump tron snap to v2.0.0, bump bitcoin snap to v2.0.0#45142taran-a wants to merge 1 commit into
taran-a wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Contributor
Builds ready [78335a5]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 5 warn · 🔴 3 fail)
Bundle size diffs
|
Contributor
Builds ready [78335a5]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 5 warn · 🔴 3 fail)
Bundle size diffs
|
Contributor
Builds ready [78335a5]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 5 warn · 🔴 3 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tron snap package bump v1.33.1 -> v2.0.0
[2.0.0]
Changed
@metamask/keyring-apifrom^23.2.0to^23.7.0(#43)@metamask/keyring-snap-sdkfrom^8.0.0to^9.2.1(#43)@metamask/snaps-clifrom^8.3.0to^8.4.1(#43)@metamask/snaps-sdkfrom^11.1.1to^11.2.0(#43)@metamask/superstructfrom^3.2.1to^3.4.1(#43)Bitcoin snap package bump v1.14.2 -> v2.0.0
[2.0.0]
Added
bip44:derive-path,bip44:derive-index,bip44:derive-index-range, andbip44:discoveraccount creation types (#43)exportAccountmethod supporting WIF (base58) private key export (#43)parseDerivationPathto validate and parse BIP-44 derivation paths for native segwit (BIP-84) accounts (#43)Changed
createAccount, v1Keyringinterface) in favour of v2 (#43)KeyringHandlerto implementKeyringSnapRpcfrom@metamask/keyring-api/v2(#43)snap.manifest.jsonto declarederivePathcapability in thebip44keyring block (#43)[1.15.2]
Fixed
1.15.1were causing frequent 429 HTTP errors.[1.15.1]
Changed
[1.15.0]
Fixed
Changelog
CHANGELOG entry: null
Related issues
n/a
Manual testing steps
n/a
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Major-version snap upgrades affect Bitcoin/Tron account and signing paths; Bitcoin v2 removes v1 keyring API, so regressions in multichain wallet flows are possible despite no local code edits.
Overview
Bumps the preinstalled Bitcoin and Tron wallet snaps to v2.0.0 by updating
package.jsonandyarn.lockonly—no extension source changes.@metamask/bitcoin-wallet-snapmoves from ^1.14.2 to ^2.0.0, which (per the release notes) drops keyring API v1 in favor of v2, adds BIP-44 derive/discover flows and private-key export, and updates licensing layout.@metamask/tron-wallet-snapmoves from ^1.33.1 to ^2.0.0, mainly dependency bumps and the same licensing split.The extension still loads these snaps from
dist/preinstalled-snap.jsonas before; behavior changes come entirely from the new snap packages at install/build time.Reviewed by Cursor Bugbot for commit 78335a5. Bugbot is set up for automated code reviews on this repo. Configure here.