Skip to content

chore: bump tron snap to v2.0.0, bump bitcoin snap to v2.0.0 - #34192

Open
taran-a wants to merge 1 commit into
mainfrom
chore/bump-tron-bitcoin-snaps
Open

chore: bump tron snap to v2.0.0, bump bitcoin snap to v2.0.0#34192
taran-a wants to merge 1 commit into
mainfrom
chore/bump-tron-bitcoin-snaps

Conversation

@taran-a

@taran-a taran-a commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Tron snap package bump v1.33.1 -> v2.0.0

[2.0.0]

Changed

  • BREAKING: Re-licensed split into LICENSE.MIT or LICENSE.APACHE2 files (SPDX expression unchanged) (#75)
  • This package was migrated from snap-tron-wallet. See the source repository for the original changelog
  • Bump @metamask/keyring-api from ^23.2.0 to ^23.7.0 (#43)
  • Bump @metamask/keyring-snap-sdk from ^8.0.0 to ^9.2.1 (#43)
  • Bump @metamask/snaps-cli from ^8.3.0 to ^8.4.1 (#43)
  • Bump @metamask/snaps-sdk from ^11.1.1 to ^11.2.0 (#43)
  • Bump @metamask/superstruct from ^3.2.1 to ^3.4.1 (#43)

Bitcoin snap package bump v1.14.2 -> v2.0.0

[2.0.0]

Added

  • Add support for keyring API v2, including bip44:derive-path, bip44:derive-index, bip44:derive-index-range, and bip44:discover account creation types (#43)
  • Add exportAccount method supporting WIF (base58) private key export (#43)
  • Add parseDerivationPath to validate and parse BIP-44 derivation paths for native segwit (BIP-84) accounts (#43)

Changed

  • BREAKING Remove v1 keyring API support (createAccount, v1 Keyring interface) in favour of v2 (#43)
  • BREAKING: Re-licensed split into LICENSE.MIT or LICENSE.APACHE2 files (SPDX expression unchanged) (#75)
  • Migrate KeyringHandler to implement KeyringSnapRpc from @metamask/keyring-api/v2 (#43)
  • Update snap.manifest.json to declare derivePath capability in the bip44 keyring block (#43)
  • Mark accounts as exportable in the keyring account mapping (#43)

[1.15.2]

Fixed

  • Fixed RPC endpoints for mainnet and testnet (#37)
    • Endpoints introduced in version 1.15.1 were causing frequent 429 HTTP errors.

[1.15.1]

Changed

[1.15.0]

Fixed

  • Handle non-url origins (#634)
  • Display known non-URL origins in confirmations without throwing on invalid origin values (#640)

Changelog

CHANGELOG entry: null

Related issues

n/a

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

High Risk
Major-version snap upgrades affect Bitcoin/Tron account creation, signing, and staking flows; Bitcoin v2 explicitly removes v1 keyring support, so runtime regressions are possible without manual multichain testing.

Overview
Bumps @metamask/bitcoin-wallet-snap from ^1.14.2 to ^2.0.0 and @metamask/tron-wallet-snap from ^1.33.1 to ^2.0.0, with matching yarn.lock resolution updates. There are no application source changes in this PR.

The Bitcoin snap major release is breaking for v1 keyring APIs and moves to keyring API v2 (BIP-44 derive/discover flows, exportable accounts, WIF export). Tron v2.0.0 mainly brings internal-snaps migration, license file split, and updated MetaMask keyring/snaps dependencies per the release notes.

Reviewed by Cursor Bugbot for commit 7e462b0. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-networks Networks team label Aug 3, 2026
@metamask-ci

metamask-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Description section is empty. Describe what changed and why.
  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions github-actions Bot added size-XS risk:medium AI analysis: medium risk labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSnaps, SmokeAccounts, SmokeNetworkExpansion, SmokeStake, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR bumps two preinstalled snap packages to major versions:

  1. @metamask/bitcoin-wallet-snap v1.14.2 → v2.0.0: This is a preinstalled snap (confirmed in app/lib/snaps/preinstalled-snaps.ts under the bitcoin build flag). It's used in app/core/SnapKeyring/BitcoinWalletSnap.ts for Bitcoin account management via SnapKeyring, and referenced in test fixtures (FixtureBuilder.ts). A major version bump could introduce breaking changes in snap API, keyring behavior, or account derivation.

  2. @metamask/tron-wallet-snap v1.33.1 → v2.0.0: This is a preinstalled snap (under the tron build flag). It's used in app/core/SnapKeyring/TronWalletSnap.ts and extensively in Earn/staking hooks (useTronStake, useTronUnstake, useTronClaimUnstakedTrx). A major version bump could break TRX staking flows.

Tag selection rationale:

  • SmokeSnaps: Primary tag — both are preinstalled snaps; snap lifecycle, preinstalled snap tests, and snap keyring tests are directly affected by these version bumps.
  • SmokeAccounts: Bitcoin wallet snap is used in SnapKeyring for non-EVM account management (BIP-44 key derivation, account creation/import). Major version changes could affect account management flows.
  • SmokeNetworkExpansion: Both Bitcoin and Tron are non-EVM chains. The snap packages enable non-EVM blockchain support. Changes to these snaps could affect multi-chain provider behavior.
  • SmokeStake: Tron wallet snap is directly used in Earn/staking hooks (useTronStake, useTronUnstake, useTronClaimUnstakedTrx). A major version bump could break TRX staking flows.
  • SmokeConfirmations: Required as a dependent tag when SmokeStake is selected (staking involves on-chain transactions requiring confirmations).

Performance Test Selection:
The changes are limited to major version bumps of two preinstalled snap packages (bitcoin-wallet-snap and tron-wallet-snap). These are snap-specific packages that handle non-EVM blockchain functionality. There is no evidence these changes affect app launch time, login performance, asset loading, swap flows, onboarding, account list rendering, or any other performance-measured scenario. No performance test tags are warranted.

View GitHub Actions results

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​1.14.2 ⏵ 2.0.010010081 -199 +1100
Updatednpm/​@​metamask/​tron-wallet-snap@​1.33.1 ⏵ 2.0.0100 +1100100 +5100 +1100

View full report

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium AI analysis: medium risk size-XS team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant