feat: extract exo utilities into @metamask/kernel-exo package#866
Open
feat: extract exo utilities into @metamask/kernel-exo package#866
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
grypez
force-pushed
the
grypez/exo-genesis
branch
from
141160e to
1fb6bc9
Compare
Remove private flag, add LICENSE files, README, changelog:update script, and constraint-required fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
grypez
force-pushed
the
grypez/exo-genesis
branch
from
1fb6bc9 to
a273069
Compare
Contributor
Member
|
@grypez I'm a little concerned about the proliferation of packages in the monorepo. Since we were using export paths, forking exos out of kernel-utils doesn't really benefit us or our consumers in and of itself, and the new package depends on kernel-utils anyway. We talked about there being some kind of build / bundle issue, but I can't remember it. Do you know what that was or do you have some other specific problem in mind? |
Contributor
Author
|
The bundling issue is already resolved by the export paths. It's just a question of ergonomics. EDIT: Actually, since our move to vite for vat bundling, we shouldn't even need the export paths anymore as we can tree shake vat bundles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exo utilities already had their own subpaths, it was inevitable they would end up here.
Future site of ocap sheaves.
Note
Medium Risk
Broad dependency/import refactor across multiple packages plus TS project reference updates; primary risk is build/test breakage or subtle behavioral drift in shared exo helpers, not security-sensitive logic.
Overview
Introduces a new standalone package,
@metamask/kernel-exo, exportingmakeDefaultExo,makeDefaultInterface,makeDiscoverableExo, and theJsonSchema/MethodSchema/DiscoverableExotypes (with its own build/test config and licensing files).Updates the monorepo to depend on and reference
kernel-exo(package deps + TS project references) and switches all call sites from@metamask/kernel-utils(and its former./exo/./discoverablesubpath exports) to@metamask/kernel-exo, while removing those exo-related exports and dependencies fromkernel-utils.Written by Cursor Bugbot for commit a273069. This will update automatically on new commits. Configure here.