Skip to content

fix: show source account in SignTransaction dialog - #174

Merged
stanleyyconsensys merged 1 commit into
mainfrom
fix/sign-tx-source-acc
Aug 7, 2026
Merged

fix: show source account in SignTransaction dialog#174
stanleyyconsensys merged 1 commit into
mainfrom
fix/sign-tx-source-acc

Conversation

@stanleyyconsensys

@stanleyyconsensys stanleyyconsensys commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Explanation

https://www.loom.com/share/e2b9b9c6aeb74e86946167bb78ee680c

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@stanleyyconsensys
stanleyyconsensys requested a review from a team as a code owner August 6, 2026 15:18
@stanleyyconsensys
stanleyyconsensys requested a lite review from Copilot August 6, 2026 15:18
);
};

const AddressRow = ({

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address field should not use in sign dialog, becoz we wanna to show the address and allow user to copy

@wantedsystem wantedsystem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@stanleyyconsensys
stanleyyconsensys merged commit 3346bf7 into main Aug 7, 2026
10 of 11 checks passed
@stanleyyconsensys
stanleyyconsensys deleted the fix/sign-tx-source-acc branch August 7, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants