fix: source account not show - #175
Merged
Merged
Conversation
| {t('confirmation.transaction.param.source')} | ||
| </SnapText> | ||
| <Copyable value={operationJson.explicitSource} /> | ||
| <Copyable value={operationJson.source} /> |
Collaborator
Author
There was a problem hiding this comment.
source is either the operation source or the txn source
operation source over the txn source
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Stellar Snap’s sign-transaction confirmation UI to display an operation’s effective source account (including inherited transaction source), addressing cases where the source was previously omitted from the view.
Changes:
- Switches source rendering from
explicitSource(only set when the operation overrides source) to the resolvedsourcefield. - Hides the source row when the operation source matches the signer account address to avoid redundant UI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremytsng
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist