Conversation
LaithSaq
reviewed
Oct 9, 2025
| redis: {} | ||
| redis: | ||
| image: | ||
| registry: docker.io |
Contributor
There was a problem hiding this comment.
Do we need to explictly mention the registry here? Do we want that for the other images as well?
Author
There was a problem hiding this comment.
No we don't. I copy pasted from actual values.yaml from the redis helm chart and forgot to delete this portion from here. Thanks, have removed it now. 😃
LaithSaq
requested changes
Oct 9, 2025
LaithSaq
left a comment
LaithSaq
left a comment
Contributor
There was a problem hiding this comment.
Can you squash the two commits together? To have a cleaner history 😁
ankur512512
force-pushed
the
INFRA-252-update-middlemail-to-use-bitnamilegacy-repo
branch
from
October 10, 2025 05:51
3d5ecdc to
5a18166
Compare
Author
Sure, squashed both the commits into one now. 🔨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating this to absorb the change caused by: bitnami/charts#35164