PRODENG-3100 updates and linting (before ticket)#605
Merged
james-nesbitt merged 2 commits intomainfrom Jan 14, 2026
Merged
Conversation
Collaborator
james-nesbitt
commented
Jan 13, 2026
james-nesbitt
commented
- dropped mkex code (mkex support deprecated as it has its own toolset now)
- go vendor upgrade
- go test fixes
- pkg/helm cert-manager based helm chart fixes, as the chart is now an oci chart
- golangci-lint upgrade & fixes
- rewrite product/mke/api -> product/mke/config (golangci-lint)
- rewrite product/common/api -> product/common/config
- dropped golangci-lint varnamelen (not really a big deal here)
james-nesbitt
force-pushed
the
PRODENG-3100-lint-and-refactor
branch
from
4390afc to
e97fe8d
Compare
- dropped mkex code (mkex support deprecated as it has its own toolset
now)
- go vendor upgrade
- go test fixes
- pkg/helm cert-manager based helm chart fixes, as the chart is now an
oci chart
- golangci-lint upgrade & fixes
- rewrite product/mke/api -> product/mke/config (golangci-lint)
- rewrite product/common/api -> product/common/config
- dropped golangci-lint varnamelen (not really a big deal here)
- terraform examples module upgrade
Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
james-nesbitt
force-pushed
the
PRODENG-3100-lint-and-refactor
branch
from
e97fe8d to
605a465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.