Skip to content

feature/battery optimization reminder#6235

Open
SeniorZhai wants to merge 2 commits intomasterfrom
codex/battery-optimization-reminder
Open

feature/battery optimization reminder#6235
SeniorZhai wants to merge 2 commits intomasterfrom
codex/battery-optimization-reminder

Conversation

@SeniorZhai
Copy link
Member

No description provided.

@SeniorZhai SeniorZhai added the testing Now testing, but you can review label Mar 19, 2026
@SeniorZhai SeniorZhai requested a review from Copilot March 19, 2026 05:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a battery-optimization reminder flow using the existing Compose bottom-sheet reminder system, replacing the prior dedicated dialog activity approach.

Changes:

  • Introduces a new BatteryOptimizationReminder popup type and UI copy (Battery_Optimization) across multiple locales.
  • Refactors ReminderPage to take pre-resolved content text (String) so callers can use stringResource(...) directly.
  • Centralizes battery optimization detection/navigation in ContextExtension and removes the old BatteryOptimizationDialogActivity + legacy triggers.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Adds Battery_Optimization string (default locale).
app/src/main/res/values-zh-rTW/strings.xml Adds Traditional Chinese translation for Battery_Optimization.
app/src/main/res/values-zh-rCN/strings.xml Adds Simplified Chinese translation for Battery_Optimization.
app/src/main/res/values-ru/strings.xml Adds Russian translation for Battery_Optimization.
app/src/main/res/values-ja/strings.xml Adds Japanese translation for Battery_Optimization.
app/src/main/res/values-es/strings.xml Adds Spanish translation for Battery_Optimization.
app/src/main/java/one/mixin/android/ui/home/reminder/VerifyMobileReminderBottomSheetDialogFragment.kt Updates reminder page content argument to pass a String via stringResource.
app/src/main/java/one/mixin/android/ui/home/reminder/ReminderPage.kt Changes content parameter from @StringRes Int to String; removes internal stringResource(content) lookup.
app/src/main/java/one/mixin/android/ui/home/reminder/ReminderBottomSheetDialogFragment.kt Adds battery optimization reminder selection + UI; updates other reminder content to pass strings.
app/src/main/java/one/mixin/android/ui/home/MainActivity.kt Removes legacy battery optimization check and related imports.
app/src/main/java/one/mixin/android/ui/common/BatteryOptimizationDialogActivity.kt Deletes the old dialog activity implementation.
app/src/main/java/one/mixin/android/job/BlazeMessageService.kt Removes background-triggered battery optimization dialog; centralizes restriction check.
app/src/main/java/one/mixin/android/extension/ContextExtension.kt Adds isBatteryOptimizationRestricted() and openBatteryOptimizationSetting() helpers.
app/src/main/AndroidManifest.xml Removes BatteryOptimizationDialogActivity registration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import one.mixin.android.ui.common.MixinComposeBottomSheetDialogFragment
import one.mixin.android.ui.home.MainActivity
import one.mixin.android.ui.setting.SettingActivity
import one.mixin.android.util.RomUtil
Comment on lines +120 to +123
return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
R.string.setting_battery_optimize_title_one_ui_above_s
} else {
R.string.setting_battery_optimize_title_one_ui_below_s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Now testing, but you can review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants