fix: remove unused notionItems variable in CalendarSyncTab#1478
fix: remove unused notionItems variable in CalendarSyncTab#1478lepitaaar wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning
|
| Cohort / File(s) | Summary |
|---|---|
MSW 핸들러 단순화 frontend/src/mocks/handlers/promotion.ts |
POST 핸들러에서 요청 바디 파싱 로직(await request.json())을 제거하고, 요청 내용에 관계없이 고정된 JSON 응답을 반환하도록 간소화. |
스타일 컴포넌트 정리 frontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.ts |
사용되지 않는 TypeScript 인터페이스(MenuItemProps, ExpandButtonProps) 2개 제거. |
미사용 임포트 제거 frontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsx, frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx, frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx, frontend/src/pages/MainPage/components/Popup/Popup.tsx |
미사용 라이브러리 임포트(useQueryClient, useEffect, useNavigate) 및 디스트럭처링(notionItems) 제거. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
- [feature] 대표 지원서 모아보기를 추가한다. #878: ApplicationRowItem.style.ts 파일에 추가된 인터페이스/스타일과 이 PR에서 제거되는 인터페이스와 관련.
- [feature] Google 캘린더 연동 기능 구현 #1371: CalendarSyncTab.tsx의 Google 캘린더 관련 주요 리팩토링과 이 PR의 미사용 변수 제거가 같은 파일 대상.
- [release] FE v1.5.0 #1386: promotion.ts의 모킹된 프로모션 데이터 업데이트와 이 PR의 MSW 핸들러 변경이 같은 파일 대상.
Suggested labels
💻 FE
Suggested reviewers
- suhyun113
- seongwon030
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | PR title focuses on CalendarSyncTab's notionItems removal, but changeset includes 5 files with multiple unrelated cleanup changes (unused imports/variables across different components and mock handlers). | Update title to reflect all changes, e.g., 'fix: remove unused variables and imports across components' or create separate focused PRs for each concern. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/remove-unused-notion-items
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
✅ UI 변경사항 없음
전체 56개 스토리 · 22개 컴포넌트 |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/src/mocks/handlers/promotion.ts (1)
53-53: 불필요한async키워드 제거 고려요청 바디 파싱(
await request.json())이 제거되면서 핸들러 내부에 더 이상await가 없습니다. 일관성과 가독성을 위해async도 함께 제거하는 것을 권장합니다.♻️ 제안 diff
- http.post(`${API_BASE_URL}/api/promotion`, async () => { + http.post(`${API_BASE_URL}/api/promotion`, () => { return HttpResponse.json({ data: { id: `article-${Date.now()}`, message: '홍보글이 성공적으로 등록되었습니다.', }, }); }),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/src/mocks/handlers/promotion.ts` at line 53, The POST handler passed to http.post(`${API_BASE_URL}/api/promotion`, async () => { ... }) no longer uses await, so remove the unnecessary async modifier; change the handler from async () => { ... } to a plain () => { ... } in promotion.ts (the http.post call) and ensure the handler still returns the same mock response shape/value so behavior and tests remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@frontend/src/mocks/handlers/promotion.ts`:
- Line 53: The POST handler passed to http.post(`${API_BASE_URL}/api/promotion`,
async () => { ... }) no longer uses await, so remove the unnecessary async
modifier; change the handler from async () => { ... } to a plain () => { ... }
in promotion.ts (the http.post call) and ensure the handler still returns the
same mock response shape/value so behavior and tests remain unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4394ae82-f602-416f-ac2b-4527b33e8919
📒 Files selected for processing (6)
frontend/src/mocks/handlers/promotion.tsfrontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.tsfrontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsxfrontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsxfrontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsxfrontend/src/pages/MainPage/components/Popup/Popup.tsx
💤 Files with no reviewable changes (4)
- frontend/src/pages/MainPage/components/Popup/Popup.tsx
- frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx
- frontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.ts
- frontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsx
|
Maintainer 요청에 따라 자동 생성 PR 운영을 중단하며 본 PR을 닫습니다. 필요 시 수동으로 재개하겠습니다. |
Automated technical debt resolution: Removed an unused
notionItemsvariable that was triggering an ESLint warning in CalendarSyncTab.tsx.Summary by CodeRabbit
릴리스 노트