Skip to content

fix: remove unused notionItems variable in CalendarSyncTab#1478

Closed
lepitaaar wants to merge 3 commits into
mainfrom
fix/remove-unused-notion-items
Closed

fix: remove unused notionItems variable in CalendarSyncTab#1478
lepitaaar wants to merge 3 commits into
mainfrom
fix/remove-unused-notion-items

Conversation

@lepitaaar
Copy link
Copy Markdown
Contributor

@lepitaaar lepitaaar commented Apr 17, 2026

Automated technical debt resolution: Removed an unused notionItems variable that was triggering an ESLint warning in CalendarSyncTab.tsx.

Summary by CodeRabbit

릴리스 노트

  • Refactor
    • 불필요한 임포트 제거로 코드베이스 정리
    • 미사용 인터페이스 및 변수 제거
    • 요청 처리 로직 단순화

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Apr 17, 2026 11:35am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

이 PR은 사용되지 않는 임포트와 변수들을 제거하고 MSW 핸들러를 단순화합니다. 여러 파일에서 미사용 코드를 정리하고, 프로모션 API 핸들러의 요청 바디 파싱을 제거합니다.

Changes

Cohort / File(s) Summary
MSW 핸들러 단순화
frontend/src/mocks/handlers/promotion.ts
POST 핸들러에서 요청 바디 파싱 로직(await request.json())을 제거하고, 요청 내용에 관계없이 고정된 JSON 응답을 반환하도록 간소화.
스타일 컴포넌트 정리
frontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.ts
사용되지 않는 TypeScript 인터페이스(MenuItemProps, ExpandButtonProps) 2개 제거.
미사용 임포트 제거
frontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsx, frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx, frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx, frontend/src/pages/MainPage/components/Popup/Popup.tsx
미사용 라이브러리 임포트(useQueryClient, useEffect, useNavigate) 및 디스트럭처링(notionItems) 제거.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

💻 FE

Suggested reviewers

  • suhyun113
  • seongwon030
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR title focuses on CalendarSyncTab's notionItems removal, but changeset includes 5 files with multiple unrelated cleanup changes (unused imports/variables across different components and mock handlers). Update title to reflect all changes, e.g., 'fix: remove unused variables and imports across components' or create separate focused PRs for each concern.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-unused-notion-items

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

✅ UI 변경사항 없음

구분 링크
📖 Storybook https://67904e61c16daa99a63b44a7-iaulsgculi.chromatic.com/

전체 56개 스토리 · 22개 컴포넌트

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
frontend/src/mocks/handlers/promotion.ts (1)

53-53: 불필요한 async 키워드 제거 고려

요청 바디 파싱(await request.json())이 제거되면서 핸들러 내부에 더 이상 await가 없습니다. 일관성과 가독성을 위해 async도 함께 제거하는 것을 권장합니다.

♻️ 제안 diff
-  http.post(`${API_BASE_URL}/api/promotion`, async () => {
+  http.post(`${API_BASE_URL}/api/promotion`, () => {
     return HttpResponse.json({
       data: {
         id: `article-${Date.now()}`,
         message: '홍보글이 성공적으로 등록되었습니다.',
       },
     });
   }),
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@frontend/src/mocks/handlers/promotion.ts` at line 53, The POST handler passed
to http.post(`${API_BASE_URL}/api/promotion`, async () => { ... }) no longer
uses await, so remove the unnecessary async modifier; change the handler from
async () => { ... } to a plain () => { ... } in promotion.ts (the http.post
call) and ensure the handler still returns the same mock response shape/value so
behavior and tests remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@frontend/src/mocks/handlers/promotion.ts`:
- Line 53: The POST handler passed to http.post(`${API_BASE_URL}/api/promotion`,
async () => { ... }) no longer uses await, so remove the unnecessary async
modifier; change the handler from async () => { ... } to a plain () => { ... }
in promotion.ts (the http.post call) and ensure the handler still returns the
same mock response shape/value so behavior and tests remain unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4394ae82-f602-416f-ac2b-4527b33e8919

📥 Commits

Reviewing files that changed from the base of the PR and between 0ec3a42 and 1b25ec1.

📒 Files selected for processing (6)
  • frontend/src/mocks/handlers/promotion.ts
  • frontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.ts
  • frontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsx
  • frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx
  • frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx
  • frontend/src/pages/MainPage/components/Popup/Popup.tsx
💤 Files with no reviewable changes (4)
  • frontend/src/pages/MainPage/components/Popup/Popup.tsx
  • frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx
  • frontend/src/pages/AdminPage/components/ApplicationRow/ApplicationRowItem.style.ts
  • frontend/src/pages/AdminPage/tabs/CalendarSyncTab/CalendarSyncTab.tsx

@lepitaaar
Copy link
Copy Markdown
Contributor Author

Maintainer 요청에 따라 자동 생성 PR 운영을 중단하며 본 PR을 닫습니다. 필요 시 수동으로 재개하겠습니다.

@lepitaaar lepitaaar closed this Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant