Import EU Feeds by ianktc · Pull Request #1371 · MobilityData/mobility-database-catalogs

ianktc · 2026-04-22T19:56:57Z

#1332: https://gtfs-validator-results.mobilitydata.org/25975383-6a3d-4543-b07c-fca5399411c9/report.html
#1310: https://gtfs-validator-results.mobilitydata.org/31a7ffb8-b3db-4eb6-8f09-90d01d3a30e1/report.html
#1260: https://gtfs-validator-results.mobilitydata.org/5f315840-2385-4ac7-ac9b-ab36e0a3007b/report.html
#1309: https://gtfs-validator-results.mobilitydata.org/c4c12aa0-e6bd-4ebe-b431-6e8ab049b9a4/report.html
#1279: https://gtfs-validator-results.mobilitydata.org/1a4c4912-e2e2-4260-a3d5-cb51c920e766/report.html

…dresses issue #1279

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds and updates GTFS schedule + GTFS-RT catalog entries for several EU providers, including deprecations and URL fixes.

Changes:

Added new GTFS schedule source JSON entries for PL/LT/IT/DE providers.
Added new GTFS-RT (vehicle positions / trip updates) source JSON entries for IT/HU providers.
Deprecated an older Kutno feed entry and redirected it to the new source; updated Metro de Madrid download URL to HTTPS.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
catalogs/sources/gtfs/schedule/pl-mazowieckie-kutno-mzk-kutno-gtfs-3125.json	New Kutno schedule feed definition (replacement target for deprecated entry).
catalogs/sources/gtfs/schedule/pl-mazowieckie-kutno-mzk-kutno-gtfs-2846.json	Marks old Kutno feed deprecated and adds redirect metadata.
catalogs/sources/gtfs/schedule/pl-koleje-slaskie-gtfs-3122.json	New Koleje Śląskie schedule feed definition.
catalogs/sources/gtfs/schedule/lt-vsI-zaliasis-regionas-gtfs-3121.json	New Lithuanian schedule feed definition.
catalogs/sources/gtfs/schedule/it-metropolitana-di-catania-ferrovia-circumetnea-gtfs-3124.json	New Catania metro schedule feed definition (inactive).
catalogs/sources/gtfs/schedule/es-madrid-metro-de-madrid-gtfs-794.json	Switches direct download URL from HTTP to HTTPS.
catalogs/sources/gtfs/schedule/de-optima-express-gtfs-3123.json	New Optima Express schedule feed definition.
catalogs/sources/gtfs/realtime/it-federico-autolinee-rt-vp-3118.json	New Autolinee Federico GTFS-RT vehicle positions feed definition.
catalogs/sources/gtfs/realtime/hu-tukebusz-gtfs-rt-vp-3120.json	New Tükebusz GTFS-RT vehicle positions feed definition.
catalogs/sources/gtfs/realtime/hu-tukebusz-gtfs-rt-tu-3119.json	New Tükebusz GTFS-RT trip updates feed definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-22T20:04:40Z

+    "provider": "Metropolitana di Catania - Ferrovia Circumetnea",
+    "name": "Ferrovia Circumetnea",
+    "status": "inactive",
+    "is_official": "True",


"is_official" is encoded as a string ("True") rather than a JSON boolean. This can break schema validation and downstream consumers expecting a boolean; change it to true (without quotes).

Suggested change

"is_official": "True",

"is_official": true,

Copilot · 2026-04-22T20:04:41Z

+            "maximum_latitude": "51.209250",
+            "minimum_longitude": "18.226595",
+            "maximum_longitude": "20.015326",
+            "extracted_on": "2026-04-22T19:12:54.475596"


"extracted_on" is missing an explicit timezone designator (e.g., 'Z' or '+00:00'). This makes the timestamp ambiguous and can lead to inconsistent parsing; please serialize timestamps in a consistent ISO-8601 format with timezone (and apply the same normalization to the other newly added files that omit the timezone).

Suggested change

"extracted_on": "2026-04-22T19:12:54.475596"

"extracted_on": "2026-04-22T19:12:54.475596Z"

Copilot · 2026-04-22T20:04:41Z

+        "municipality": "Kutno",
+        "bounding_box": {
+            "minimum_latitude": null,
+            "maximum_latitude": null,
+            "minimum_longitude": null,
+            "maximum_longitude": null,
+            "extracted_on": "2026-04-22T18:44:40+00:00"
+        }


The bounding box coordinates are present but set to null. If the catalog schema (or consumers) expects numeric coordinates, null values can fail validation or crash parsing. Prefer either (a) providing actual numeric bounds, or (b) omitting the bounding_box (or individual keys) entirely when unknown, depending on the catalog’s schema conventions.

Suggested change

"municipality": "Kutno",

"bounding_box": {

"minimum_latitude": null,

"maximum_latitude": null,

"minimum_longitude": null,

"maximum_longitude": null,

"extracted_on": "2026-04-22T18:44:40+00:00"

}

"municipality": "Kutno"

Copilot · 2026-04-22T20:04:41Z

+            "id": "3125",
+            "comment": " "


The redirect "id" is a string while mdb_source_id values are numeric elsewhere, and the redirect "comment" is effectively empty (single space). To avoid type mismatches and unclear metadata, store id as a number and either remove the comment field or provide a meaningful explanation (e.g., 'Replaced by new endpoint').

Suggested change

"id": "3125",

"comment": " "

"id": 3125,

"comment": "Replaced by new endpoint"

Copilot · 2026-04-22T20:04:42Z

+    "mdb_source_id": 3122,
+    "data_type": "gtfs",
+    "provider": "Koleje Śląskie",
+    "name": "railway",


The "name" field value ("railway") looks like a mode/category rather than a dataset name, and it’s inconsistent with other entries in this PR where "name" is a proper feed/network name (e.g., "Ferrovia Circumetnea"). If "name" is intended to be a human-readable dataset name, update it to the feed/network’s name (or drop the field if optional) and use the appropriate field for mode/category if one exists in the catalog schema.

Suggested change

"name": "railway",

"name": "Koleje Śląskie",

Copilot · 2026-04-22T20:04:42Z

+    ],
+    "provider": "Tükebusz",
+    "urls": {
+        "direct_download": "http://menobusz.tukebusz.hu:30080/mobilapp/GTFS/RTx_positions.x",


This GTFS-RT endpoint uses plain HTTP, which allows tampering/mitm of realtime data in transit. If an HTTPS endpoint is available, prefer it; if HTTP is the only option, consider adding/using an authenticated proxy over HTTPS (where supported by the ingestion system) to protect data integrity.

Suggested change

"direct_download": "http://menobusz.tukebusz.hu:30080/mobilapp/GTFS/RTx_positions.x",

"direct_download": "https://menobusz.tukebusz.hu:30080/mobilapp/GTFS/RTx_positions.x",

none available

Copilot · 2026-04-22T20:04:42Z

+        "authentication_type": 0
+    }
+}
+


There appears to be an extra trailing blank line at end-of-file. It’s minor, but keeping these JSON files consistently formatted reduces noisy diffs and helps automated formatting/validation tools.

Suggested change

ianktc · 2026-04-22T20:28:21Z

Hi @jcpitre I used the same prompts that you did for reviewing this PR in Copilot CLI. Everything lgtm, we can refine the prompts as we move forward with more PRs too. Could you approve when you have the chance?

copilot-session-0d65522f-439c-42ef-bed5-7b8c278ca668.html

ianktc added 8 commits April 22, 2026 13:22

add Federico Autolinee vehicle positions feed; addresses #1269

b25a7ff

update direct download URL for Madrid Red de Metro; addresses #1262

03bf12b

add new Tükebusz realtime tu and vp feeds; addresses #1259

9f581c6

add Žaliasis regionas schedule feed; addresses #1310

352a014

add Koleje Śląskie schedule feed; addresses #1260

56f3909

add Optima Express schedule feed; addresses #1309

2444e01

add Ferrovia Circumetnea - Metropolitana di Catania schedule feed; ad…

13678ae

…dresses issue #1279

update direct download URL for MZK Kutno schedule feed; addresses #1332

2aa0dfc

ianktc self-assigned this Apr 22, 2026

ianktc added feed submission region/europe labels Apr 22, 2026

ianktc requested a review from Copilot April 22, 2026 20:01

Copilot started reviewing on behalf of ianktc April 22, 2026 20:01 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

string to float

d68c611

jcpitre reviewed Apr 23, 2026

View reviewed changes

Comment thread catalogs/sources/gtfs/realtime/hu-tukebusz-gtfs-rt-tu-3119.json

ianktc requested a review from jcpitre April 23, 2026 15:48

jcpitre approved these changes Apr 23, 2026

View reviewed changes

ianktc merged commit 134c6d7 into main Apr 23, 2026
10 checks passed

ianktc deleted the import/eu-apr-22 branch April 23, 2026 16:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import EU Feeds#1371

Import EU Feeds#1371
ianktc merged 9 commits intomainfrom
import/eu-apr-22

ianktc commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

ianktc Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

ianktc commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"extracted_on": "2026-04-22T19:12:54.475596"
	"extracted_on": "2026-04-22T19:12:54.475596Z"

	"direct_download": "http://menobusz.tukebusz.hu:30080/mobilapp/GTFS/RTx_positions.x",
	"direct_download": "https://menobusz.tukebusz.hu:30080/mobilapp/GTFS/RTx_positions.x",

Conversation

ianktc commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

ianktc Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

ianktc commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants