Android: return existing VkSurface on VK_ERROR_NATIVE_WINDOW_IN_USE_KHR - #5
Open
whitebelyash wants to merge 1 commit into
Open
Android: return existing VkSurface on VK_ERROR_NATIVE_WINDOW_IN_USE_KHR#5whitebelyash wants to merge 1 commit into
whitebelyash wants to merge 1 commit into
Conversation
Fixes VulkanMod on 26.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most desktop platforms support multiple Vulkan surfaces on a single window. Android does not.
This caused weird crashes when running VulkanMod dev builds. Still not sure if it's a mistake on VKMod side or we actually have to handle these situations.
Currently only Vulkan is handled: GLFW will return already created VkSurface object if new requested. EGL will require destroying EGLSurface object.