Skip to content

python module to json files#69

Open
loriab wants to merge 2 commits intoMolSSI:masterfrom
loriab:json_files
Open

python module to json files#69
loriab wants to merge 2 commits intoMolSSI:masterfrom
loriab:json_files

Conversation

@loriab
Copy link
Copy Markdown
Collaborator

@loriab loriab commented Mar 3, 2020

Description

Sound the waters to convert the hand-edited QCSchema in python module format into a collection of raw JSON schema autogenerated by Pydantic from QCElemental models (that get tested). Relevant discussion on #68. This is all generated by make qcschema over at QCEl, then copying the files.

Do Not Merge Now

Things that haven't been done include:

  • moving existing to a maintenance branch
  • checking that hand-edited details here are in the qcel docstrings so that they'll show up again here at qcsk.
  • checking that schemas are 1-to-1.

Status

  • Ready to go

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Mar 3, 2020

This pull request fixes 5 alerts when merging ff79030 into 54fabe9 - view on LGTM.com

fixed alerts:

  • 5 for Module imports itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant