Skip to content

feat: add input validation for setup tools - #325

Closed
galjos wants to merge 1 commit into
devfrom
feature/input-validation-review
Closed

feat: add input validation for setup tools#325
galjos wants to merge 1 commit into
devfrom
feature/input-validation-review

Conversation

@galjos

@galjos galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member

Recreates #322 after #324 restored dev. This PR requires review before merge.

Summary

  • add stable help, version, capabilities, and validation CLI contracts
  • return file- and line-aware diagnostics for parser and cross-field errors
  • install external-QM scripts, references, and Slakos assets relocatably
  • harden temperature, progress, and cell-list edge cases

Integration

  • PQSetup uses --capabilities=json for version, build, runner, default, and range discovery
  • PQSetup uses --validate run.in --format=json for authoritative checks
  • PQSetup keeps local v0.6.4 checks when PQ does not advertise this contract

Validation

  • recreated source tree exactly matches the tested feat: add input validation for setup tools #322 head
  • shared Debug: 153/153
  • static Release/Singularity: 153/153
  • shared Release/ASE: 154/154, including staged Slakos install
  • the identical tree passed the full GitHub matrix and both coverage gates

@galjos
galjos requested review from 97gamjak and ape33 July 28, 2026 14:50
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.62861% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.31%. Comparing base (262484e) to head (5b3911d).

Files with missing lines Patch % Lines
src/input/inputFileReader.cpp 67.44% 14 Missing ⚠️
src/input/inputValidation.cpp 93.79% 8 Missing ⚠️
src/output/references/referencesOutput.cpp 83.33% 7 Missing ⚠️
...c/input/inputFileParser/convergenceInputParser.cpp 89.36% 5 Missing ⚠️
src/input/inputFileParser/hybridInputParser.cpp 81.81% 4 Missing ⚠️
src/input/commandLineArgs.cpp 95.74% 0 Missing and 2 partials ⚠️
src/input/inputFileParser/manostatInputParser.cpp 88.88% 2 Missing ⚠️
src/input/inputFileParser/optInputParser.cpp 93.10% 2 Missing ⚠️
src/setup/thermostatSetup.cpp 60.00% 2 Missing ⚠️
src/utilities/executablePath.cpp 85.71% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #325      +/-   ##
==========================================
+ Coverage   89.81%   90.31%   +0.50%     
==========================================
  Files         293      293              
  Lines       11420    11787     +367     
  Branches     3600     3772     +172     
==========================================
+ Hits        10257    10646     +389     
+ Misses       1122     1099      -23     
- Partials       41       42       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pq-perf-bot

pq-perf-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M -0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M -0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M -0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@galjos
galjos marked this pull request as draft July 28, 2026 15:07
@galjos

galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Superseded by focused issue/PR pairs. Each PR is ready for peer review and requests ape33 and 97gamjak.

CLI and validation

Runtime correctness

Installation and data

Documentation

Suggested stack order:

#370 also waits for #336 and #347. #373 also waits for #365, #367, and #368 and needs its temporary executable-path helper removed after #365 lands.

Whitespace-only changes and the incorrect t_relaxation = 1.0 ps documentation change were intentionally not carried forward.

@galjos galjos closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant