Add clangd tidy checks - #409
Open
97gamjak wants to merge 47 commits into
Open
Conversation
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #409 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 294 294
Lines 11477 11480 +3
Branches 3599 3600 +1
=======================================
+ Hits 10309 10312 +3
Misses 1126 1126
Partials 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Ready to review? @97gamjak |
97gamjak
marked this pull request as ready for review
July 31, 2026 06:25
Collaborator
Author
forgot to change status 🫣 |
galjos
requested changes
Jul 31, 2026
|
|
||
| - name: Run clangd-tidy | ||
| run: | | ||
| clangd-tidy $(find src/ apps/ include/ -name "*.cpp" ! -name "moc_*.cpp" 2>/dev/null) -p=build |
Member
There was a problem hiding this comment.
does include/ make sense if you only search for *.cpp files?
Comment on lines
+17
to
+18
| - 'CMakeLists.txt' | ||
| push: |
Member
There was a problem hiding this comment.
Suggested change
| - 'CMakeLists.txt' | |
| push: | |
| - 'CMakeLists.txt' | |
| - '.clang-tidy' | |
| - 'scripts/clang_tidy.sh' | |
| - '.github/workflows/lint.yml' | |
| push: |
Comment on lines
+32
to
+33
| - 'CMakeLists.txt' | ||
| workflow_dispatch: |
Member
There was a problem hiding this comment.
Suggested change
| - 'CMakeLists.txt' | |
| workflow_dispatch: | |
| - 'CMakeLists.txt' | |
| - '.clang-tidy' | |
| - 'scripts/clang_tidy.sh' | |
| - '.github/workflows/lint.yml' | |
| workflow_dispatch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #402