UI adjustments & video_player new features#604
Conversation
…e, ui is now centered accordingly
…anDown disabled due to interference with onTap on desktop
…e interacted with in the controls overlay after this. & Height adapted for mobile and tv interfaces
…content after outro, if there is, standard skip outro button will show. New setting for user to force next_up button in all cases
|
"Auto-Hide Prompts: "Skip Intro/Outro" and "Next Up" widgets now automatically hide after 10 seconds of playback. They reappear if the user brings up the controls overlay." -- There is already a setting for Next Up: "Next Up Timeout" which should be respected beyond the 10 seconds. |
|
Even if it's hidden from the player screen, the countdown will still continue, it's just to not have the widget always on screen if you want to see the media playing during this time. But you're absolutely right for Next Up setting, for Skip Intro/Outro however there were no such settings. |
|
Yes, that is what I was getting at - for the opening/closing credits, the hide/show behaviour is probably good (e.g., a 2-minute long opening credits sequence, might want to watch part of it then skip); but for the Next Up display which triggers after playback has ended, it shouldn't disappear since it is the only thing active on the screen. |
|
You are right I totally forgot about that. What do you think about this fix? It checks if it's at the end of the media with a margin of 2sec and if it is it doesn't launch the timer: Old code: New code: Tried it and it works, I also corrected the comments that were in French sorry. |
|
I'm just providing some input but it is up to @RadicalMuffinMan to review the PR and see if he agrees. I still don't think your new logic works perfectly though -- since many users use the "Replace Skip Outro with Next Up Display" toggle which will trigger outside of the interval you've indicated. The auto-hide should simply never apply to the Next Up display, regardless of when it triggers. |
|
Ok I see! My logic was just to hide the big widget that was in the middle of the screen (especially on mobile) just so you can watch the outro in the meantime (I know you can use the minimal one that's smaller). But I totally understand your way of seeing it. |
|
If you don't want to see the big widget, you should leave the "Replace Skip Outro with Next Up Display" setting off. Then during the outro, you would only get a small "Skip Outro?" popup. That's the whole point of that setting. |
|
I think some users, like myself, still like to have the countdown of the next_up widget so you don't have to interact with the remote or the screen to first skip_outro and then next_up. But it's a minor inconvenience really, you can call that laziness :) I started to develop it to hide the skip intro/outro button after 10sec and then added it to Next Up to have the same behavior for everything. Let's see what RadicalMuffinMan says, but I will happily remove this behavior if you two prefer! |
Pull Request
Summary
This PR introduces several quality-of-life improvements and fixes to the Video Player. Updates include a smarter "Next Up" logic that protects post-credits scenes, auto-hiding behavior for skip widgets, and UI adjustments to ensure transport controls remain perfectly centered across all states. It also addresses a controls overlay bug specific to the web platform.
Type of Change
Changes Made
UI Adjustments:
hasAnyNavigationlogic. The previous/next queue arrows are now always rendered in the layout (grayed out when unavailable). This prevents layout shifts and ensures the center transport controls (Play/Pause, Seek forward/backward) remain perfectly centered on screen.New Features:
Bug Fixes:
Platform
Testing
Describe how this change was tested.
Test Steps
Checklist