Update App Theme and Interface Style settings pane for 2.3#697
Open
mattsigal wants to merge 1 commit into
Open
Update App Theme and Interface Style settings pane for 2.3#697mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
- Modified English localizations in app_en.arb to update main theme tile, custom theme headings/descriptions, default theme subtitle, and interface style descriptions. - Replaced Material 3 SegmentedButton with custom tab segment row widget in adaptive_segmented.dart to allow independent focus borders (pink outline) and selection underlines (like detail page subtabs). - Added ScrollController and ancestor Focus listener to ListView in appearance_theme_screen.dart to auto-scroll the viewport back to 0.0 when D-pad focus returns to the segmented buttons. - Shrunk theme preview gradient heights to 52, centered navigation pills, and reduced typography sizes for compact preview cards. - Repositioned interface style description before segmented control and adjusted list spacing padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This pull request updates the App Theme and Interface Style settings pane layout, text descriptions, selection borders, focus outlines, and scrolling behavior to align with the visual and accessibility requirements and to highlight the changes coming in 2.3!
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Original
App Theme description
Removes hard-coded theme names also mentions Interface Style.
App Theme Pane Update:
Checklist