homeRows and detailsSection style changes#116
Open
harleykradovill wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR updates the styling of
homeRowsand thedetailsSectionabove them. It adds rounded corners to posters, replaces the focus image, and limits the focus region to the poster itself. ThedetailsSectiontext now matches the sizing and spacing of the media bar.Type of Change
Changes Made
HomeRowItemsSizesso the focus cursor only appears around the poster, just like the core app.detailsSectionto match the media bar.Testing
This was tested using the demo server for Jellyfin. I confirmed that Movies, TV Shows, and Music all display their masks correctly. Posters that do not match these sizes will not display a mask. I also made sure the TMDB/MDBList ratings displayed correctly by testing with my own server.
Further testing with Kefintweaks and HSS may be needed. Nothing in this PR should break those, but styling wise I am not sure.
Screenshots
Before:

After:

Checklist