chore: Bump XTerm.NET from 1.2.0 to 2.0.1 - #44
Conversation
--- updated-dependencies: - dependency-name: XTerm.NET dependency-version: 2.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| <PackageVersion Include="TUnit.Core" Version="1.65.68" /> | ||
| <PackageVersion Include="WireMock.Net" Version="2.15.0" /> | ||
| <PackageVersion Include="XTerm.NET" Version="1.2.0" /> | ||
| <PackageVersion Include="XTerm.NET" Version="2.0.1" /> |
There was a problem hiding this comment.
WARNING: XTerm.NET bumped 1.2.0 -> 2.0.1 (semver-major; 2.0.0 is a substantial rewrite per the release notes) without a lockstep SvcSystems.UI.Terminal bump.
The app reaches XTerm.NET through two paths this PR does not touch: directly via XtermTerminalSurface.cs (subscribes Model.Terminal.Engine.DataReceived, types XTerm.Events.TerminalEvents.DataEventArgs whose .Data is a string); and through the SvcSystems.UI.Terminal wrapper, which exposes Model.Terminal.Engine (XTerm.Terminal) and is pinned by TerminalTranscriptTests against Engine.Buffer.Lines, BufferCell.Content, AttributeData.IsBold/GetFgColor, IsAlternateBufferActive, the \x1b[?1049h alt-screen toggle, and the DSR cursor-position reply flow.
SvcSystems.UI.Terminal stays at 1.1.2, which the repo's own history records as targeting the XTerm.NET 1.x line (commit 31227c5: 'XTerm.NET moves to 1.1.0, the new floor'; design doc 'Supply chain' risk note records the coupling). Compatibility of the 1.1.2 wrapper and its direct XTerm.NET consumers with the 2.0 rewrite is not established here.
Before merge: confirm the resolved graph compiles and TerminalTranscriptTests passes against 2.0.1 -- its assertions (SGR 31 -> GetFgColor()==1, alt-screen entry/exit, DSR round-trip) are exactly what a major engine rewrite can shift. If a SvcSystems.UI.Terminal release built against XTerm.NET 2.0 exists, bump both together.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Verify before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 changed file + context consumers)
Review scope: Code-review sweep of this semver-major Dependabot bump (1 file, 1 changed line) in READ-ONLY, non-interactive mode; no build or test execution. Model: kilo code-review sweep (kilo/poolside/laguna-s-2.1:free). The fidelity guard is Documentation hygiene (out of scope for this PR): Fix these issues in Kilo Cloud Reviewed by laguna-s-2.1:free · Input: 239.6K · Output: 42.6K · Cached: 912.4K |
Updated XTerm.NET from 1.2.0 to 2.0.1.
Release notes
Sourced from XTerm.NET's releases.
2.0.0
What's Changed
... (truncated)
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)