fix: fix for bug introduced in 0.17.2 blocking range orders

[arkanoider]

Title

fix: allow range orders with fiat_amount == 0 in order_action

Summary

v0.17.2 started validating every new order with check_fiat_amount() unconditionally. Range orders encode the band with min_amount / max_amount and use fiat_amount == 0, so they were rejected before range handling ran. This change calls check_fiat_amount() only for single-amount orders (no min/max), restoring correct behavior for range listings without changing mostro-core.

Changes

• In order_action (src/app/order.rs), gate check_fiat_amount() on min_amount and max_amount both absent.
• Add a short comment explaining why (strict core check vs range placeholder fiat).

Summary by CodeRabbit

• Bug Fixes
  • Fixed order validation logic to properly handle both single-amount and range orders. Range orders can now process without triggering fiat amount validation errors.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d24c8ba-c081-49d9-b690-870d37b862f5

📥 Commits

Reviewing files that changed from the base of the PR and between 2d96531 and 9314771.

📒 Files selected for processing (1)

• src/app/order.rs

---

Walkthrough

The order_action function in src/app/order.rs is modified to conditionally validate fiat_amount only for single-amount orders. The check_fiat_amount() validation is now skipped for range orders where fiat amount is expected to be zero. All other validations and control flow remain unchanged.

Changes

Cohort / File(s)	Summary
Conditional Fiat Validation src/app/order.rs	Modified order_action to call check_fiat_amount() only when both min_amount and max_amount are None, bypassing this validation for range orders where fiat amount should be zero.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Add check_fiat_amount and check_amount validations to SmallOrder mostro-core#135: Directly addresses the conditional invocation of check_fiat_amount() in order_action for single-amount orders only, aligning with the check's intended usage.

Possibly related PRs

• fix: validate fiat_amount and amount in order_action #702: Also modifies validation logic in order_action by adding unconditional calls to check_fiat_amount() and check_amount(), touching the same validation pathway.
• disallow premium with fixed order #400: Modifies order validation conditionals in order_action for handling amount/premium constraints, overlapping in the validation orchestration logic.
• Right condition to check if premium is accepted #430: Adjusts validation conditionals in order_action for order parameter handling, similarly affecting amount and fiat validation flow.

Suggested reviewers

• grunch
• Catrya
• AndreaDiazCorreia

Poem

🐰 A careful hop through validation's maze,
Range orders skip the fiat gaze,
While single-amount hops still play by rules,
Smart conditions now our safety tools! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: addressing a regression in v0.17.2 that was blocking range orders, which aligns with the code change.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-range-orders

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Catrya]

tACK

[grunch]

LGTM