Repository navigation
feat(video-to-bootanim): improve dropzone accessibility and format support - #3
Merged
Merged
Conversation
…pport Add keyboard navigation (Enter/Space) and ARIA attributes for dropzone. Expand video file acceptance to include .mov and .mkv formats. Co-authored-by: Zainab Adina <274186811+19-AKA-HH@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
MKV support has an unresolved browser-decoding/error-state gap, and the visible format guidance is inconsistent.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Improves the video dropzone’s accessibility and expands supported video formats.
Changes:
- Adds keyboard activation, button semantics, ARIA labeling, and focus styling.
- Adds MOV/MKV format handling.
- Updates upload validation and format guidance.
| File | Summary |
|---|---|
src/app/video-to-bootanimation/components/VideoDropZone.tsx |
Adds accessibility behavior and expanded format handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+77
to
78
| accept="video/mp4,video/webm,video/quicktime,video/x-matroska" | ||
| onChange={onSelect} |
| {isDragging ? "Drop your video here" : "Click or drag & drop to select"}{" "} | ||
| <code className="font-mono bg-neutral-100 dark:bg-neutral-900 px-1 rounded border border-neutral-200 dark:border-neutral-850"> | ||
| .mp4 / .webm | ||
| .mp4 / .webm / .mov |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the video-to-bootanimation dropzone with keyboard navigation, ARIA attributes, and extended video format support (.mov, .mkv).