Repository navigation
BACK-793 - Keep cleanup previews current and archive selected tasks efficiently - #1154
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Groma architecture comparison
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c05317c7ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Alex's Agent: Please review the updated head 39a6107. The independent review findings about cross-branch identity checks and stale fallback paths are fixed, with three regressions that failed before the corrections. All 79 focused tests, types, formatting and build pass. The 100-task benchmark still uses two reads of each corpus. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Alex's Agent: The second maintenance review found no actionable bugs or necessary simplifications. It verified the branch-aware identity checks, refreshed fallback targets, request invalidation, duplicate-submit guard, lock order and per-task failures, and judged the structure reasonable for a junior maintainer. Hosted Codex review of 39a6107 is also clean, and the addressed review thread is resolved. Waiting for the remaining CI jobs before merge. |
|
@codex review Alex's Agent: Final head 5c12935 adds a bounded retry for a task disappearing between enumeration and metadata stats. Selected and unselected task-move regressions failed before the fix and now pass; repeated missing files stop after three attempts. This addresses the second independent correctness review's remaining finding. All 82 distinct focused tests, types, formatting and build pass. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Alex's Agent: Independent Codex review of final correction 5c12935 found no actionable bugs and passed all 28 cleanup tests plus type checking. The prior full maintenance review is clean; the final addition is a small, commented three-attempt loop that preserves other errors. All reproduced review findings now have passing regressions. |
Changing the cleanup age while its confirmation is open can leave the previous Archive action available. Late preview responses can also restore an old selection after closing the dialog. Keep age and task IDs in one selection state, invalidate older requests, and guard archive execution so it submits the confirmed IDs once.
Cleanup also scanned the entire board and archive for each selected task. It now locks the selected tasks, refreshes identity once under the allocator lock, and uses the same archive move/commit helper as single-task archive. Reopened and ambiguous tasks are checked under locks. A busy task falls back to per-task processing so the other tasks can still be archived; a started batch is never retried.
Validation: 82 focused UI, HTTP, core, CLI-input, archive-folder and commit-scope tests pass, plus types, Biome, TSX formatting and build. New regressions failed before the change. A disposable 100-task benchmark fell from 301 board/archive reads each to two each (about 823 ms to 64 ms locally). Review findings about branch identities, fallback paths and concurrent file moves during metadata loading are covered by regressions and corrected. Snapshot retries stop after three missing-file races. Live browser testing was attempted but the browser runtime failed to import; the DOM and HTTP flow tests passed.
Closes #1045