Repository navigation
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web UI now follows the OS color scheme until the user picks a theme.
ThemeContextkeeps the OS scheme in state and updates it from aprefers-color-schemechange listener, so an open tab switches live.backlog-theme-choicekey. Toggling back to the theme the OS shows removes the key, so the UI follows the OS again. The single toggle button is unchanged.backlog-themekey held a theme written on every load, not a real choice, so it is no longer read. Existing users follow the OS after upgrading.index.htmlapplies the same rule, so the page doesn't flash the wrong theme.Related Issue or Task
Closes #1158, BACK-795
Task Checklist
backlog/tasks/Testing
src/test/web-theme.test.tsxcovers following OS changes, storing nothing on load, pinning, clearing the choice and ignoring the old key. All four cases failed before the change.bun run check:types,bun run check .,bun run buildand all 387 web tests pass.backlog-theme=darkvalue is ignored.index.htmlpre-render script alone picks the expected theme for each combination of stored choice and OS scheme.