Skip to content

Conversation

@michaelmackenzie
Copy link
Contributor

No description provided.

@FNALbuild
Copy link
Collaborator

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for c41285f: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at c41285f.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c41285f at a04e36a
build (prof) Log file. Build time: 04 min 32 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file. Return Code 1.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 🔶 2 errors 11 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at c41285f after being merged into the base branch at a04e36a.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@brownd1978
Copy link
Collaborator

Out of curiosity, how are EWM produced Online? The only producer I know of is the MC one.

@michaelmackenzie
Copy link
Contributor Author

I'm not positive if we are Online yet, I don't think I've seen an Online producer for this either. We could add a producer to make this object from the CFO fragment or DTC subevent header I believe. For now, the best place might be the EventHeaderFromCFOFragment module.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the PrefetchDAQData module by adding support for prefetching EventWindowMarker (EWM) and ProtonBunchTime (PBT) data products, and migrates the module from using legacy fhicl::ParameterSet to the validated FHiCL configuration pattern using art::EDProducer::Table<Config>.

Changes:

  • Migrated constructor from fhicl::ParameterSet to validated configuration using Config struct and Parameters typedef
  • Added EWM and PBT data products to the prefetch mechanism with corresponding configuration parameters and member variables
  • Added includes for EventWindowMarker and ProtonBunchTime data product headers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants