-
Notifications
You must be signed in to change notification settings - Fork 95
Add EWM and PBT to prefetch, change to validated config #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @michaelmackenzie,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for c41285f: build (Build queue - API unavailable) |
|
☀️ The build tests passed at c41285f.
N.B. These results were obtained from a build of this Pull Request at c41285f after being merged into the base branch at a04e36a. For more information, please check the job page here. |
|
Out of curiosity, how are EWM produced Online? The only producer I know of is the MC one. |
|
I'm not positive if we are Online yet, I don't think I've seen an Online producer for this either. We could add a producer to make this object from the CFO fragment or DTC subevent header I believe. For now, the best place might be the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request enhances the PrefetchDAQData module by adding support for prefetching EventWindowMarker (EWM) and ProtonBunchTime (PBT) data products, and migrates the module from using legacy fhicl::ParameterSet to the validated FHiCL configuration pattern using art::EDProducer::Table<Config>.
Changes:
- Migrated constructor from
fhicl::ParameterSetto validated configuration usingConfigstruct andParameterstypedef - Added EWM and PBT data products to the prefetch mechanism with corresponding configuration parameters and member variables
- Added includes for EventWindowMarker and ProtonBunchTime data product headers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.