Persist partition state and use integration testing#2409
Open
john- wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
Open
Persist partition state and use integration testing#2409john- wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
john- wants to merge 2 commits intoMusicPlayerDaemon:masterfrom
Conversation
Author
|
I am closing this to investigate an issue with how this interacts with myMPD on its first use of MPD with the new state file. |
Author
|
It turns out issue I encountered is unrelated to these mpd changes and unrelated to myMPD. The problem was a timing issue on boot when mounting my music library over nfs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the persisting of state information for all partitions.
The testing is done by executing the minimum needed MPD code in order to test the StateFile class. I would consider it integration testing.
The previous pull request for this functionality had testing that was more like system testing: The entire mpd applcation is loaded and interacted with via its inputs/outputs (e.g. configuration file).
High level notes:
test/meson.buildwas modified to create a testing library file that includes at least enough MPD to compile the test cases.Mocking (gmock) is used for loading songs into the playlist and for mounting storage.
Stock MPD functionality requires songs be in the MPD DB and use of valid storage. The mocking overrides this behavior for testing.
I reviewed the comments for the previous pull request and attempted to address them with this testing approach.
If there is too much basic stuff I am missing give me the feedback you have time for.