Skip to content

Check the signed withdrawal with bitcoind before finalizing, and refuse on script failures - #1305

Merged
zhouwfang merged 1 commit into
mainfrom
zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing
Oct 6, 2026
Merged

zhouwfang merged 1 commit into
mainfrom
zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing

Conversation

@zhouwfang

Copy link
Copy Markdown
Contributor

@zhouwfang
zhouwfang marked this pull request as ready for review September 30, 2026 21:25
@zhouwfang
zhouwfang requested a review from bmwill as a code owner September 30, 2026 21:25
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-06 18:54 UTC

0xsiddharthks added a commit that referenced this pull request Oct 5, 2026
ts-sdks e7708a442 (#1305) removed the dead devnet guardian client from the
packages/hashi README's guardian example. The docs build re-fetches that
README, so the docs job's `make is-dirty` fails on every PR until main has
the regenerated page.
@zhouwfang
zhouwfang force-pushed the zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing branch 3 times, most recently from cba910d to 8d540cf Compare October 5, 2026 23:15

@dlukegordon dlukegordon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one non-blocking alerting fix noted inline.

Comment thread crates/hashi/src/finalize_bitcoin_check.rs
@zhouwfang
zhouwfang force-pushed the zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing branch from 8d540cf to 62874ab Compare October 6, 2026 18:22
@zhouwfang
zhouwfang force-pushed the zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing branch from 62874ab to da1ae36 Compare October 6, 2026 18:36
@zhouwfang
zhouwfang enabled auto-merge (squash) October 6, 2026 18:39
@zhouwfang
zhouwfang merged commit 07eb5b8 into main Oct 6, 2026
16 checks passed
@zhouwfang
zhouwfang deleted the zhoufang/iop-759-check-the-signed-withdrawal-with-bitcoind-before-finalizing branch October 6, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants