[attestations 3] Accept inline data:image/svg+xml in image_url - #246
Draft
mdgeorge4153 wants to merge 1 commit into
Draft
[attestations 3] Accept inline data:image/svg+xml in image_url#246mdgeorge4153 wants to merge 1 commit into
mdgeorge4153 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
July 24, 2026 11:37
43b34a8 to
d27d01f
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
July 24, 2026 18:22
d27d01f to
2a36b0b
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
July 30, 2026 18:24
2a36b0b to
0cae354
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
2 times, most recently
from
August 5, 2026 21:03
6013f5d to
b5ab106
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 5, 2026 21:38
b5ab106 to
bf62cad
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 6, 2026 16:43
bf62cad to
4aee203
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 7, 2026 13:42
4aee203 to
7755c21
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 14, 2026 21:00
7755c21 to
68026f4
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 14, 2026 21:18
68026f4 to
2a81a85
Compare
mdgeorge4153
force-pushed
the
mdgeorge/source-verification-1-inline-svg
branch
from
August 20, 2026 11:06
2a81a85 to
2dff757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend counterpart to the attestations repo's inline-SVG
CONVENTIONS.mdchange (MystenLabs/attestations#4). First PR in the source-verification stack; stacked on #245 (basemdgeorge/attestation-grpc).Problem
The attestation badge fed
image_urlthroughhttpsLink, which only acceptshttps://. So an inlinedata:image/svg+xmlbadge — the point of the convention change — was silently dropped and fell back to the attester avatar.Change
imageSourcehelper: accepts anhttpsURL or adata:image/svg+xmlURI (raw,;base64,, and;charset=…,forms). Used only for the badge.linkkeepshttpsLink(https-only) — adata:link target isn't wanted.Safety
The value goes only into an
<img src>, where a<script>oronloadinside the SVG does not execute — which is the rule the convention spells out (render in<img>, never inline into the DOM). Rejected:http, otherdata:types (data:text/html,…), prefix-spoofs (data:image/svg+xmlEVIL),javascript:.Verification
TSC clean; the accept/reject logic is unit-checked against the cases above. Not yet visually confirmed against a real attestation — none of the testnet attesters set
image_urlyet (that's exactly the source-verification badge work coming next in the stack).🤖 Generated with Claude Code
https://claude.ai/code/session_01GqiELJtBuhYBp2W35ExHCk