feat(graphql): parameterize BigInt on inner type - #298
Open
amnn wants to merge 1 commit into
Open
Conversation
## Description Previously the SDK assumed all GraphQL `BigInt` values could fit inside a `u64`, but this is not the case. GraphQL uses `BigInt` to represent any integer value that couldn't fit in 53 bits (so doesn't get represented as a JSON number), which means it could be used to represent a `u128` or `i128` (as in the case of a balance change). This change parameterizes `BigInt` with a sealed inner numeric type that defaults to `u64` for backwards compatibility. ## Test plan ``` $ cargo nextest run -p sui-graphql -- scalars ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the SDK assumed all GraphQL
BigIntvalues could fit inside au64, but this is not the case. GraphQL usesBigIntto represent any integer value that couldn't fit in 53 bits (so doesn't get represented as a JSON number), which means it could be used to represent au128ori128(as in the case of a balance change).This change parameterizes
BigIntwith a sealed inner numeric type that defaults tou64for backwards compatibility.Test plan