refactor(graphql): switch from apollo-compiler to bluejay - #302
Open
amnn wants to merge 1 commit into
Open
Conversation
## Description
Use `bluejay` for GraphQL query parsing and validation in the macro,
instead of `apollo-parser`. This cuts down the number of dependencies
pulled in by the macro (inclusive) from 74 to 39 (a reduction of almost
half -- 35 dependencies removed).
`bluejay` is the GraphQL stack from Shopify. It offers the same
functionality modulo error message wording, but with less of a hit on
build times.
A reduction of 35 dependencies makes a big difference to a project like
jellyfish.
## Test plan
Run existing tests:
```
cargo nextest run -p sui-graphql-macros
```
Check dependency tree:
```
$ cargo tree -p sui-graphql-macros -e normal --prefix none \
| sed 's/ (\*)$//' \
| sort -u \
| wc -l
39
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
bluejayfor GraphQL query parsing and validation in the macro, instead ofapollo-parser. This cuts down the number of dependencies pulled in by the macro (inclusive) from 74 to 39 (a reduction of almost half -- 35 dependencies removed).bluejayis the GraphQL stack from Shopify. It offers the same functionality modulo error message wording, but with less of a hit on build times.A reduction of 35 dependencies makes a big difference to a project like jellyfish.
Test plan
Run existing tests:
Check dependency tree: