sui-indexer-alt-reader: merge AlphaLedgerGrpcReader into LedgerGrpcReader - #27723
Open
evan-wall-mysten wants to merge 1 commit into
Conversation
evan-wall-mysten
requested review from
amnn,
nickvikeras,
tpham-mysten and
wlmyng
August 17, 2026 17:18
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 17, 2026 17:18 — with 
GitHub Actions
Active
GitHub Actions
Active
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
evan-wall-mysten
force-pushed
the
evan-wall-mysten/merge-alpha-ledger-grpc-reader
branch
from
August 17, 2026 18:27
9305fed to
0434d34
Compare
evan-wall-mysten
changed the base branch from
evan-wall-mysten/remove-list-apis-postgres-fallback
to
evan-wall-mysten/kv-rpc-remove-list-apis-flag
August 17, 2026 18:27
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 17, 2026 18:27 — with
GitHub Actions
Active
GitHub Actions
Active
evan-wall-mysten
force-pushed
the
evan-wall-mysten/merge-alpha-ledger-grpc-reader
branch
from
August 17, 2026 18:47
0434d34 to
e917e38
Compare
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 17, 2026 18:47 — with
GitHub Actions
Active
GitHub Actions
Active
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 17, 2026 18:47 — with
GitHub Actions
Active
GitHub Actions
Active
amnn
approved these changes
Aug 18, 2026
| /// A frame with none of the known fields set (unknown/future frame kind). | ||
| Unknown, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
nit: the constants are conventionally put before the types.
…ader The List APIs are no longer alpha as of this PR, so fold list_transactions/list_events (and StreamPage/PageItem) into LedgerGrpcReader instead of maintaining a second gRPC connection and reader type for them.
evan-wall-mysten
force-pushed
the
evan-wall-mysten/merge-alpha-ledger-grpc-reader
branch
from
August 18, 2026 17:51
e917e38 to
f5cc924
Compare
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 17:52 — with
GitHub Actions
Active
GitHub Actions
Active
evan-wall-mysten
deployed
to
sui-typescript-aws-kms-test-env
August 18, 2026 17:52 — with
GitHub Actions
Active
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #27712.
The gRPC List APIs (
ListTransactions/ListEvents) are no longer alpha as of #27666 — they're the only path now, withAlphaLedgerGrpcReaderopened as a second, separate gRPC connection to the sameledger_grpc_urlalongsideLedgerGrpcReader's point-lookup connection. This foldslist_transactions/list_events(andStreamPage/PageItem) directly intoLedgerGrpcReader, deletesAlphaLedgerGrpcReader, and updates the GraphQL server to construct and register a single reader instead of two.Side effect: the separate
graphql_alpha_ledger_grpcmetrics prefix is gone — List/Stream calls now report under the samegraphql_ledger_grpcprefix as point lookups. Checkeddashboards/for references to the old prefix; found none.Test plan
cargo check/clippyclean onsui-indexer-alt-reader,sui-indexer-alt-graphql,sui-indexer-alt-jsonrpc,sui-indexer-alt-e2e-tests. All 27sui-indexer-alt-readerlib tests pass (including the movedledger_grpc_reader::tests::*stream-draining tests).cargo fmtclean.Release notes