Skip to content

docs(mvr-static): clarify static name detection - #1218

Draft
clud-bot[bot] wants to merge 1 commit into
mainfrom
clud/clarify-mvr-static-readme
Draft

clud-bot[bot] wants to merge 1 commit into
mainfrom
clud/clarify-mvr-static-readme

Conversation

@clud-bot

@clud-bot clud-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Clarify how mvr-static scans source text for package names and types, with concrete literal examples. Document unsupported dynamic construction such as interpolation, concatenation, variables, imports, and helpers, along with scan-scope caveats.

Test plan

  • npx --yes prettier@3.9.6 --check packages/mvr-static/README.md
  • git diff --check

AI Assistance Notice

Please disclose the usage of AI. This is primarily to help inform reviewers of how careful they need to review PRs, and to keep track of AI usage across our team. Please fill this out accurately, and do not modify the content or heading for this section!

  • This PR was primarily written by AI.
  • I used AI for docs / tests, but manually wrote the source code.
  • I used AI to understand the problem space / repository.
  • I did not use AI for this PR.

🤖 Generated with Clud · View thread

@vercel

vercel Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
sui-typescript-docs Ignored Ignored Preview Aug 21, 2026 9:46am

Request Review

@clud-bot
clud-bot Bot temporarily deployed to sui-typescript-aws-kms-test-env August 21, 2026 09:46 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

```ts
const pkg = '@org/app';
const interpolated = `${pkg}::coin::Coin`; // Type is not detected.
const concatenated = pkg + '::coin::Coin'; // Type is not detected.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript can infer these, I wonder how hard it would be for us to do the same

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clud-bot can you investigate if there is an easy way to extract constant strings like these (without pulling in large dependencies). (could we use the typescript compiler api for this)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clud-bot don't make the changes, just report findings

This branch was previously deployed

1 inactive deployment
sui-typescript-aws-kms-test-env — 9163571c Deployed Aug 21, 2026 by clud-bot[bot] via Lint, Build, and Test #4866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants