Repository navigation
feat(sdk): add ask() method to MemWal and MemWalMock (#1067) - #1345
Open
harrymove-ctrl wants to merge 2 commits into
Open
harrymove-ctrl wants to merge 2 commits into
harrymove-ctrl wants to merge 2 commits into
Conversation
2 tasks done
harrymove-ctrl
force-pushed
the
feat/issue-1067-ts-sdk-ask
branch
2 times, most recently
from
November 3, 2026 16:10
fa07e9f to
e697338
Compare
Collaborator
Author
|
Rebased onto latest dev to resolve mock client validation conflict with PR #1342. All 393 SDK unit and integration tests pass. |
harrymove-ctrl
force-pushed
the
feat/issue-1067-ts-sdk-ask
branch
from
November 4, 2026 18:59
e697338 to
f0674fe
Compare
Collaborator
Author
|
Rebased onto dev cleanly. All 393 TypeScript SDK tests pass. Ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
ask()on bothMemWalandMemWalMockin@mysten-incubation/memwalso TypeScript SDK consumers can queryPOST /api/askdirectly with parity alongside the Python SDK and Rust relayer.AskMemory,AskResult,AskOptions, andAskParamstopackages/sdk/src/types.tsand exported them frompackages/sdk/src/index.ts.MemWal.ask()inpackages/sdk/src/memwal.tssupporting both object-styleask({ question, limit, namespace, scoringWeights, timeoutMs })and positionalask(question, limit?, namespace?)/ask(question, options?).question(non-blank),limit(positive integer, default5),scoringWeights(finite numbers), and responsememoriesarray shape before returning.MemWalMock.ask()inpackages/sdk/src/mock.tswith identical input validation and deterministic offline recall synthesis.packages/sdk/test/ask.test.mjsand updatedpackages/sdk/README.md.Fixes #1067
Verification
pnpm --filter @mysten-incubation/memwal buildpnpm --filter @mysten-incubation/memwal test(375/375 tests passing)