[harrymove-ctrl]

Summary

• Add looksLikeOptOut and looksLikeSecret checks in packages/openclaw-memory-memwal/src/capture.ts ahead of TRIGGER_PATTERNS so explicit conversational opt-out directives (such as do not remember, don't save, off the record, [no-save]) and inline secret patterns (suiprivkey1, vendor API keys, PEM blocks, Bearer headers, and labelled 64-hex keys) are rejected locally before registerCaptureHook calls client.analyze().
• Add unit and hook-level regression tests in packages/openclaw-memory-memwal/test/capture-optout.test.mjs.

Verification

• Reproduced with @mysten-incubation/dev-wallet before and after the fix: shouldCapture now returns false for both opt-out and secret turns and registerCaptureHook sends 0 requests to /api/analyze.
• pnpm --dir packages/openclaw-memory-memwal test (48 passed).

[harrymove-ctrl]

@ducnmm This PR is ready for review at commit 5059165. All 22/22 CI checks are passing.

[ducnmm]

The tightened opt-out patterns now miss ordinary explicit requests not to save a turn. Offline probes of the current capture module return hasCaptureOptOut=false and shouldCapture=true for the examples below; full package/live tests were not rerun.

[ducnmm]

[P2] Keep ordinary do-not-save phrases in the opt-out filter

The new object whitelist after save/store excludes common explicit instructions such as “Please don’t save any of this: I prefer working from Tokyo next month” and “Do not save or remember this: my temporary medical appointment is at 3 PM.” Both now return hasCaptureOptOut=false and shouldCapture=true in this exact module, whereas the previous broader pattern rejected them. Because the hook uses the same predicate to suppress trailing assistant replies, the opted-out content and its echoes can reach analyze(). Extend the imperative grammar to cover these forms and add hook-level regression tests while retaining the ordinary developer-prose cases.

[harrymove-ctrl]

Extended the opt-out grammar to support compound verbs like save or remember and any-of targets like don't save any of this. Added unit and hook-level regression tests in commit 6d0049e.

[ducnmm]

The two previously reported forms are now excluded correctly, but the combined pattern introduces another opt-out regression. Four focused opt-out tests passed using the current TypeScript source with Node type stripping; an offline hook probe still forwarded the explicit do-not-remember turn and its assistant acknowledgement to analyze(). Full package and live tests were not rerun.

[ducnmm]

[P2] Preserve explicit remember opt-outs with other objects

Combining remember/memorize with the save/store object whitelist makes ordinary opt-outs such as “Do not remember the following: I prefer working from Tokyo next month.” and “Please don't remember where I live: 123 Example Street.” return hasCaptureOptOut=false and shouldCapture=true. Both were rejected at the previous head. The hook therefore leaves optOutActive false and forwards both the user content and the trailing assistant acknowledgement to analyze(); the offline hook probe produced one request containing both messages. Keep the broader object handling for explicit remember/memorize imperatives, or cover these forms without weakening the developer-prose exclusions, and add a hook regression.

[harrymove-ctrl]

@ducnmm Kept the broader object handling for explicit remember and memorize imperatives while preserving save and store object constraints and developer-prose exclusions in commit feec570. Added unit and hook-level regression tests for remember directives with other targets.

[ducnmm]

The previously reported remember opt-outs are fixed and the four focused source-level tests pass. Offline predicate and hook probes found a new regression: ordinary coordinated first-person statements are now classified as opt-outs and the hook drops both the statement and the assistant reply. Full package and live tests were not rerun.

[ducnmm]

[P2] Preserve coordinated first-person developer statements

The shared prefix accepts and/but, so broadening remember to any object now treats ordinary statements such as “I prefer Rust but don't remember when we adopted it.” and “We use Postgres and don't remember why we picked that version.” as instructions not to save the turn. Both return hasCaptureOptOut=true and shouldCapture=false here, while the previous head captured them. The hook also suppresses the trailing assistant response; an offline hook probe made zero analyze calls for the Rust preference plus its acknowledgement. Distinguish coordinated first-person prose from an imperative before marking the whole turn opted out, and add a regression alongside the standalone “I don't remember” case.

[harrymove-ctrl]

Fixed in 84bffe3. Broadened remember/memorize opt-out matching now requires a clause-initial or polite imperative boundary (CLAUSE_IMPERATIVE_PREFIX), while coordinated conjunctions (and, but, ,) only trigger when paired with an explicit persistence verb or deictic turn target (this, that, it, anything, the following, the conversation). Added unit and hook-level regressions for coordinated first-person statements like "I prefer Rust but don't remember when we adopted it." and "We use Postgres and don't remember why we picked that version.".

[ducnmm]

The coordinated first-person examples now remain capturable, and the four focused source-level tests pass, including the earlier opt-out and assistant-echo regressions. An offline predicate/hook probe found a new boundary regression: an explicit privacy-directed remember opt-out after a comma now forwards the user content and assistant acknowledgement to analyze(). Full package and live tests were not rerun.

[ducnmm]

[P2] Preserve explicit remember opt-outs after a comma

Removing the comma boundary from broad remember matching means “For privacy, don't remember my home address: 123 Example Street.” and “For privacy, do not remember where I live: 123 Example Street.” now return hasCaptureOptOut=false and shouldCapture=true. The fallback pattern also excludes my and where I, so neither explicit instruction is recognized, although both were excluded at the previous head. A hook probe for the first example now makes one analyze() call containing both the address and the assistant's acknowledgement, versus zero previously. Preserve unambiguous privacy-directed imperatives after a comma while retaining the coordinated-prose exclusions, and add a hook regression for this form.

[harrymove-ctrl]

Addressed review feedback in 93ddbf0: preserved the comma boundary in clause imperatives and added my, our, and where/what/who/how I to the remember fallback pattern while keeping coordinated-prose exclusions intact. Added unit tests for privacy-directed imperatives after commas and a hook-level regression confirming assistant echoes are suppressed.

[ducnmm]

The privacy-directed comma examples and the four focused opt-out tests pass. An offline comparison with the previous head found the new conjunction regression below; the hook forwards both the opted-out user content and its assistant acknowledgement to analyze(). No live requests were performed.

[ducnmm]

[P2] Preserve explicit opt-outs after conjunctions

Aliasing this prefix removes the previous and/but boundaries from the narrow fallback patterns. Consequently, My temporary medical appointment is at 3 PM and do not remember this. and My home address is 123 Example Street but do not save this in memory. now return hasCaptureOptOut=false and shouldCapture=true; both were excluded at the previous head. A focused hook probe makes one analyze() call containing the user message and the trailing assistant acknowledgement. Retain conjunction handling for explicit persistence verbs/deictic opt-out targets while preserving the coordinated first-person developer-prose exclusions, and add hook-level regressions for these forms.

[harrymove-ctrl]

Fixed in 1dd3efdf: restored and and but conjunction matching in IMPERATIVE_NEGATION_PREFIX for the persistence-verb (save|store|record|capture|keep), log, and deictic-object remember|memorize opt-out patterns while keeping CLAUSE_IMPERATIVE_PREFIX for the broad clause-start remember|memorize pattern. Coordinated opt-outs such as "My temporary medical appointment is at 3 PM and do not remember this." and "My home address is 123 Example Street but do not save this in memory." now return hasCaptureOptOut=true and shouldCapture=false while coordinated first-person developer prose like "I prefer Rust but don't remember when we adopted it." remains capturable. Added unit and hook-level regression tests.