Skip to content

Fix index.d.ts declaration - #17

Open
sfe-efficy wants to merge 6 commits into
N00ts:masterfrom
sfe-efficy:master
Open

sfe-efficy wants to merge 6 commits into
N00ts:masterfrom
sfe-efficy:master

Conversation

@sfe-efficy

Copy link
Copy Markdown

Using vue-tsc to generate types and export correctly the type definitinion from a template vue.
Define the type of objects required for the tree component.
Using vue-tsc is complaining about use "class" and ":class" properties with the error "Left side of comma operator is unused and has no side effects."
Update packages, it was not possible to installed with npm install before updating eslint packages.

@sfe-efficy

Copy link
Copy Markdown
Author

This is related with the issue #10

@N00ts

N00ts commented Jun 9, 2022

Copy link
Copy Markdown
Owner

I will check in coming days :)

@N00ts

N00ts commented Jun 27, 2022 •

Copy link
Copy Markdown
Owner

Hello, sorry I just cheked your PR, can you remove the package-lock.json ? I only use yarn for this project. I saw that your removed the "class" static attributes "node-wrapper" and "checkbox-wrapper", You put "node-wrapper"" in "nodeClass" but I feel like "checkbox-wrapper" just disapeared., what about it ?

Regards

@sfe-efficy

Copy link
Copy Markdown
Author

Hi! Removed the packag-lock.json

About the "checkbox-wrapper" doesn't disappeared.

The computed variable checkedClass contains the value:

image

I needed to move into the computed variable because typescript is complaining when I try to compile with the attribute "class" and ":class" (dynamic one).

image

image


But, I guess with my MR the div node original with the class name "checkbox-wrapper" is going to have the class name "checkbox-wrapper" when original was no present.

I tried to keep the double attribute "class" with and without colon, but I cannot fix the original error

@N00ts

N00ts commented Jul 5, 2022

Copy link
Copy Markdown
Owner

I can't run "yarn run all" with your branch. I'm up to date. Apparently "yarn run lint" and "yarn types" does not work anymore.

image

image

On my ubuntu 22.04 lts with node 12.22.9, after a clean repo and a yarn install, it does not seem to work.

Regards

@sfe-efficy

Copy link
Copy Markdown
Author

Hi! I guess is because "vue-tsc", at least in node 12 is not correctly of fully supported.
In my case I'm using node 16.14.2

And also, I saw that a lot of components are removing the support for node 12, for example eslint-plugin-vue or eslint-config-typescript.

@hypnotic-frog

Copy link
Copy Markdown

Hey, any advances on merging this? Thanks!

@N00ts

N00ts commented Feb 13, 2023

Copy link
Copy Markdown
Owner

I will have a look as soon as I have time :)

@scscgit

scscgit commented Jun 19, 2023

Copy link
Copy Markdown

I was just about to make a new issue about missing types... Please don't forget to make a progress with this :)

@Lisiadito

Copy link
Copy Markdown

@sfe-efficy what is the status on this?

@N00ts

N00ts commented Jan 3, 2024

Copy link
Copy Markdown
Owner

I think this PR is too old, the project has evolved since

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants