Skip to content

Implement osPfsInit and osPfsIsPlug functions with error handling #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gabryel-lima wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement osPfsInit and osPfsIsPlug functions with error handling #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ba2f79
Implement osPfsInit and osPfsIsPlug functions with error handling
Gabryel-lima May 20, 2026
6649152
Merge branch 'N64Recomp:main' into main
Gabryel-lima May 28, 2026
fe0dc0b
Add default return for error handling in error_to_string and wait_for…
Gabryel-lima May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions librecomp/src/mod_manifest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,4 +1032,6 @@ std::string recomp::mods::error_to_string(CodeModLoadError error) {
case CodeModLoadError::UnsupportedApiVersion:
return "Mod DLL has an unsupported API version";
}

return "Unknown code mod load error";
}
10 changes: 10 additions & 0 deletions librecomp/src/pak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ extern "C" void osPfsInitPak_recomp(uint8_t * rdram, recomp_context* ctx) {
ctx->r2 = 1; // PFS_ERR_NOPACK
}

extern "C" void osPfsInit_recomp(uint8_t * rdram, recomp_context * ctx) {
ctx->r2 = 1; // PFS_ERR_NOPACK
}

extern "C" void osPfsIsPlug_recomp(uint8_t * rdram, recomp_context * ctx) {
u8* pattern = _arg<1, u8*>(rdram, ctx);
*pattern = 0; // No controller pak plugged in
ctx->r2 = 0;
}

extern "C" void osPfsFreeBlocks_recomp(uint8_t * rdram, recomp_context * ctx) {
ctx->r2 = 1; // PFS_ERR_NOPACK
}
Expand Down
2 changes: 2 additions & 0 deletions librecomp/src/recomp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,8 @@ bool wait_for_game_started(uint8_t* rdram, recomp_context* context) {
case GameStatus::None:
return true;
}

return true;
}

recomp::SaveType recomp::get_save_type() {
Expand Down