Skip to content

Add default Derivation Group associations for Plans at the Model level#1934

Merged
pranav-super merged 20 commits into
developfrom
model_derivation_group-update-v2
Jun 15, 2026
Merged

Add default Derivation Group associations for Plans at the Model level#1934
pranav-super merged 20 commits into
developfrom
model_derivation_group-update-v2

Conversation

@pranav-super

@pranav-super pranav-super commented May 20, 2026

Copy link
Copy Markdown
Contributor

___REQUIRES_AERIE_PR___="1831"

This is the UI update based on the tables introduced in this Plandev PR.

It introduces a derivation group tab along with the other model association tabs on the models page.
This feature is modeled off of the other associations, but since derivation group associations are much simpler than goal/condition/constraint specifications, is a lot lighter-weight and doesn't precisely match functionality.

There are a few minor unresolved TODOs, namely:

  • deleting an external source gets blocked if there are any outstanding plan-derivation-group links.
    We don't believe this is a necessary check for model-derivation-group links (i.e. if a derivation group is linked to a model, and a planner wants to delete a source from said group, they shouldn't be blocked from doing so). We believe this is an unnecessary check because with a model, there are no activities scheduled off of any sources or external events visible to planners at a model level, so there is no anticipated loss when a source is deleted.
  • a few formatting issues with the derivation group table on the models page. The table is modeled off of the ManagePlanDerivationGroupsModal, and a lot of the formatting and divs were retained as attempts to format otherwise were unsuccessful.

Comment thread src/components/model/ModelAssociations.svelte
Comment thread src/components/model/DGModelSpecification.svelte Outdated
Comment thread src/components/model/DGModelSpecification.svelte
Comment thread src/components/model/DGModelSpecification.svelte
Comment thread src/components/model/DGModelSpecification.svelte Outdated
Comment thread src/components/model/DGModelSpecification.svelte Outdated
Comment thread src/utilities/permissions.ts
Comment thread src/routes/models/[id]/+page.svelte Outdated
Comment thread src/utilities/effects.ts Outdated
Comment thread src/utilities/effects.ts Outdated
Comment thread src/utilities/permissions.ts Outdated
Comment thread src/utilities/permissions.ts Outdated
Comment thread src/routes/models/[id]/+page.svelte Outdated
Comment thread src/utilities/gql.ts Outdated
Comment thread src/utilities/gql.ts Outdated

@AaronPlave AaronPlave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an e2e test for this workflow? Left some other comments but nothing too big to fix.

Comment thread src/utilities/effects.ts Outdated
Comment thread src/utilities/effects.ts Outdated
Comment thread src/utilities/effects.ts Outdated
Comment thread src/routes/models/[id]/+page.svelte Outdated
Comment thread src/utilities/effects.ts
@pranav-super pranav-super force-pushed the model_derivation_group-update-v2 branch from 671d258 to f3fd27e Compare June 11, 2026 18:43
Comment thread src/routes/models/[id]/+page.svelte Outdated
Comment thread src/components/model/DGModelSpecification.svelte Outdated

@AaronPlave AaronPlave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few old pieces of code to remove

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pranav-super pranav-super merged commit 6596a50 into develop Jun 15, 2026
7 of 8 checks passed
@pranav-super pranav-super deleted the model_derivation_group-update-v2 branch June 15, 2026 20:26
@AaronPlave AaronPlave added the feature New feature or request label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants