Add default Derivation Group associations for Plans at the Model level#1934
Merged
Conversation
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
requested changes
May 27, 2026
AaronPlave
left a comment
Contributor
There was a problem hiding this comment.
Could you add an e2e test for this workflow? Left some other comments but nothing too big to fix.
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
AaronPlave
reviewed
May 27, 2026
added 11 commits
June 11, 2026 11:43
671d258 to
f3fd27e
Compare
AaronPlave
reviewed
Jun 15, 2026
AaronPlave
reviewed
Jun 15, 2026
AaronPlave
approved these changes
Jun 15, 2026
AaronPlave
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a few old pieces of code to remove
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


___REQUIRES_AERIE_PR___="1831"This is the UI update based on the tables introduced in this Plandev PR.
It introduces a derivation group tab along with the other model association tabs on the models page.
This feature is modeled off of the other associations, but since derivation group associations are much simpler than goal/condition/constraint specifications, is a lot lighter-weight and doesn't precisely match functionality.
There are a few minor unresolved TODOs, namely:
We don't believe this is a necessary check for model-derivation-group links (i.e. if a derivation group is linked to a model, and a planner wants to delete a source from said group, they shouldn't be blocked from doing so). We believe this is an unnecessary check because with a model, there are no activities scheduled off of any sources or external events visible to planners at a model level, so there is no anticipated loss when a source is deleted.
ManagePlanDerivationGroupsModal, and a lot of the formatting anddivs were retained as attempts to format otherwise were unsuccessful.